From: Alex Riesen <raa.lkml@gmail.com>
To: Jeff King <peff@peff.net>
Cc: layer <layer@known.net>,
git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: [PATCH] disable post-checkout test on Cygwin
Date: Tue, 17 Mar 2009 17:26:43 +0100 [thread overview]
Message-ID: <81b0412b0903170926p4f2d536el2b96a71c79c0159e@mail.gmail.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 968 bytes --]
It is broken because of the tricks we have to play with
lstat to get the bearable perfomance out of the call.
Sadly, it disables access to Cygwin's executable attribute,
which Windows filesystems do not have at all.
Signed-off-by: Alex Riesen <raa.lkml@gmail.com>
---
t/t5403-post-checkout-hook.sh | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
2009/3/3 Jeff King <peff@peff.net>:
> +mkdir -p templates/hooks
> +cat >templates/hooks/post-checkout <<'EOF'
> +#!/bin/sh
> +echo $@ > $GIT_DIR/post-checkout.args
> +EOF
> +chmod +x templates/hooks/post-checkout
> +
> +test_expect_success 'post-checkout hook is triggered by clone' '
> + git clone --template=templates . clone3 &&
> + test -f clone3/.git/post-checkout.args
> +'
This is broken on cygwin: the hook script won't be not marked executable
by copy_file, because the native Win32 stat(2) routines are used and
report the mode of source file as 0666.
[-- Attachment #2: 0001-disable-post-checkout-test-on-Cygwin.diff --]
[-- Type: application/octet-stream, Size: 1235 bytes --]
From e5394ee710460e25369b4755798930a3f19085c5 Mon Sep 17 00:00:00 2001
From: Alex Riesen <raa.lkml@gmail.com>
Date: Tue, 17 Mar 2009 17:22:53 +0100
Subject: [PATCH] disable post-checkout test on Cygwin
It is broken because of the tricks we have to play with
lstat to get the bearable perfomance out of the call.
Sadly, it disables access to Cygwin's executable attribute,
which Windows filesystems do not have at all.
Signed-off-by: Alex Riesen <raa.lkml@gmail.com>
---
t/t5403-post-checkout-hook.sh | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/t/t5403-post-checkout-hook.sh b/t/t5403-post-checkout-hook.sh
index 4fdb418..5858b86 100755
--- a/t/t5403-post-checkout-hook.sh
+++ b/t/t5403-post-checkout-hook.sh
@@ -71,6 +71,7 @@ test_expect_success 'post-checkout receives the right args when not switching br
test $old = $new -a $flag = 0
'
+if test "$(git config --bool core.filemode)" = true; then
mkdir -p templates/hooks
cat >templates/hooks/post-checkout <<'EOF'
#!/bin/sh
@@ -82,5 +83,6 @@ test_expect_success 'post-checkout hook is triggered by clone' '
git clone --template=templates . clone3 &&
test -f clone3/.git/post-checkout.args
'
+fi
test_done
--
1.6.2.142.gaf8db
next reply other threads:[~2009-03-17 16:36 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-17 16:26 Alex Riesen [this message]
2009-03-17 16:52 ` [PATCH] disable post-checkout test on Cygwin Junio C Hamano
2009-03-17 16:59 ` Johannes Sixt
2009-03-17 20:28 ` Alex Riesen
2009-03-17 20:42 ` Junio C Hamano
2009-03-17 21:38 ` [PATCH] Define a version of lstat(2) specially for copy operation Alex Riesen
2009-03-18 3:17 ` Mark Levedahl
2009-03-18 7:22 ` Alex Riesen
2009-03-18 7:41 ` Junio C Hamano
2009-03-18 7:56 ` Johannes Sixt
2009-03-18 9:30 ` Junio C Hamano
2009-03-18 10:14 ` Johannes Sixt
2009-03-18 18:56 ` Junio C Hamano
2009-03-17 20:34 ` [PATCH] disable post-checkout test on Cygwin Alex Riesen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=81b0412b0903170926p4f2d536el2b96a71c79c0159e@mail.gmail.com \
--to=raa.lkml@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=layer@known.net \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).