From: Alex Riesen <raa.lkml@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Johannes Sixt <j.sixt@viscovery.net>, Jeff King <peff@peff.net>,
layer <layer@known.net>,
git@vger.kernel.org
Subject: Re: [PATCH] Define a version of lstat(2) specially for copy operation
Date: Wed, 18 Mar 2009 08:22:24 +0100 [thread overview]
Message-ID: <81b0412b0903180022w4b95106ds54a16a835b53c1d@mail.gmail.com> (raw)
In-Reply-To: <20090317213820.GC13458@blimp.localdomain>
2009/3/17 Alex Riesen <raa.lkml@gmail.com>:
>> hooks copied from templates? I think we could pass mode 0 to copy_files()
>> and have the function special case it (and allow a platform specific
>> copy_files() implemented by Cygwin). lstat() in the copy_templates_1()
>> codepath is primarily done to see if we need to descend into a directory
>> or symlink() and our use of st.st_mode to pass to copy_files() is a no
>> cost side effect on platforms with x-bit support.
>
> And I don't think that the platform broken in so many ways deserves
> that kind of treatment. Maybe this patch is enough. Will test it
> tomorrow, when I get to mine so much hated Windows system.
>
Ok, I just tested it and it works. Junio, this patch can replace the previous
change which disabled the test.
next prev parent reply other threads:[~2009-03-18 7:23 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-17 16:26 [PATCH] disable post-checkout test on Cygwin Alex Riesen
2009-03-17 16:52 ` Junio C Hamano
2009-03-17 16:59 ` Johannes Sixt
2009-03-17 20:28 ` Alex Riesen
2009-03-17 20:42 ` Junio C Hamano
2009-03-17 21:38 ` [PATCH] Define a version of lstat(2) specially for copy operation Alex Riesen
2009-03-18 3:17 ` Mark Levedahl
2009-03-18 7:22 ` Alex Riesen [this message]
2009-03-18 7:41 ` Junio C Hamano
2009-03-18 7:56 ` Johannes Sixt
2009-03-18 9:30 ` Junio C Hamano
2009-03-18 10:14 ` Johannes Sixt
2009-03-18 18:56 ` Junio C Hamano
2009-03-17 20:34 ` [PATCH] disable post-checkout test on Cygwin Alex Riesen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=81b0412b0903180022w4b95106ds54a16a835b53c1d@mail.gmail.com \
--to=raa.lkml@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=j.sixt@viscovery.net \
--cc=layer@known.net \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).