* [PATCH] git clone needs to know executability of template files
@ 2009-03-19 10:28 Alex Riesen
2009-03-19 10:57 ` Johannes Schindelin
0 siblings, 1 reply; 3+ messages in thread
From: Alex Riesen @ 2009-03-19 10:28 UTC (permalink / raw)
To: Git Mailing List
Cc: Johannes Sixt, Jeff King, layer, Johannes Schindelin,
Junio C Hamano
[-- Attachment #1: Type: text/plain, Size: 169 bytes --]
Use posix_lstat for template source.
Signed-off-by: Alex Riesen <raa.lkml@gmail.com>
---
builtin-init-db.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
[-- Attachment #2: 0002-git-clone-needs-to-know-executability-of-template-fil.diff --]
[-- Type: application/octet-stream, Size: 814 bytes --]
From e7b9002e3157607aa251b85e4f94f5866d9bf375 Mon Sep 17 00:00:00 2001
From: Alex Riesen <raa.lkml@gmail.com>
Date: Thu, 19 Mar 2009 11:17:59 +0100
Subject: [PATCH 2/4] git clone needs to know executability of template files
Use posix_lstat for template source.
Signed-off-by: Alex Riesen <raa.lkml@gmail.com>
---
builtin-init-db.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/builtin-init-db.c b/builtin-init-db.c
index ee3911f..0b6dc16 100644
--- a/builtin-init-db.c
+++ b/builtin-init-db.c
@@ -66,7 +66,7 @@ static void copy_templates_1(char *path, int baselen,
else
exists = 1;
- if (lstat(template, &st_template))
+ if (posix_lstat(template, &st_template))
die("cannot stat template %s", template);
if (S_ISDIR(st_template.st_mode)) {
--
1.6.2.142.gaf8db
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] git clone needs to know executability of template files
2009-03-19 10:28 [PATCH] git clone needs to know executability of template files Alex Riesen
@ 2009-03-19 10:57 ` Johannes Schindelin
0 siblings, 0 replies; 3+ messages in thread
From: Johannes Schindelin @ 2009-03-19 10:57 UTC (permalink / raw)
To: Alex Riesen
Cc: Git Mailing List, Johannes Sixt, Jeff King, layer, Junio C Hamano
Hi,
On Thu, 19 Mar 2009, Alex Riesen wrote:
> Use posix_lstat for template source.
>
> Signed-off-by: Alex Riesen <raa.lkml@gmail.com>
> ---
As this patch builds on top of your earlier patch, you should have made a
patch series.
But as I said, I think it is wrong.
Ciao,
Dscho
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] git clone needs to know executability of template files
2009-03-19 21:40 ` Alex Riesen
@ 2009-03-19 21:43 ` Alex Riesen
0 siblings, 0 replies; 3+ messages in thread
From: Alex Riesen @ 2009-03-19 21:43 UTC (permalink / raw)
To: Johannes Schindelin
Cc: Git Mailing List, Johannes Sixt, Jeff King, layer, Junio C Hamano
Use posix_lstat for template source. The copy_templates_1 needs to
know the file mode information for the copy of the template. The
copying of the executable bit always work on POSIX systems and
sometimes even on Cygwin.
Signed-off-by: Alex Riesen <raa.lkml@gmail.com>
---
builtin-init-db.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/builtin-init-db.c b/builtin-init-db.c
index ee3911f..0b6dc16 100644
--- a/builtin-init-db.c
+++ b/builtin-init-db.c
@@ -66,7 +66,7 @@ static void copy_templates_1(char *path, int baselen,
else
exists = 1;
- if (lstat(template, &st_template))
+ if (posix_lstat(template, &st_template))
die("cannot stat template %s", template);
if (S_ISDIR(st_template.st_mode)) {
--
1.6.2.1.237.g7206c6
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-03-19 21:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-03-19 10:28 [PATCH] git clone needs to know executability of template files Alex Riesen
2009-03-19 10:57 ` Johannes Schindelin
-- strict thread matches above, loose matches on Subject: below --
2009-03-19 10:27 [PATCH] Define a version of lstat(2) with posix semantics Alex Riesen
2009-03-19 10:57 ` Johannes Schindelin
2009-03-19 21:40 ` Alex Riesen
2009-03-19 21:43 ` [PATCH] git clone needs to know executability of template files Alex Riesen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).