git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Alex Riesen <raa.lkml@gmail.com>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: "Anders Melchiorsen" <mail@cup.kalibalik.dk>,
	git@vger.kernel.org, "Samuel Tardieu" <sam@rfc1149.net>,
	"Linus Torvalds" <torvalds@linux-foundation.org>,
	"Junio C Hamano" <gitster@pobox.com>,
	"SZEDER Gábor" <szeder@ira.uka.de>
Subject: [PATCH] Add a reminder test case for a merge with F/D transition
Date: Mon, 11 May 2009 11:42:17 +0200	[thread overview]
Message-ID: <81b0412b0905110242u3624f0eeyc0dc9b2b987bfa2b@mail.gmail.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 1547 bytes --]

The problem is that if a file was replaced with a directory containing
another file with the same content and mode, an attempt to merge it
with a branch descended from a commit before this F->D transition will
cause merge-recursive to break. It breaks even if there were no
conflicting changes on that other branch.

Originally reported by Anders Melchiorsen.

Signed-off-by: Alex Riesen <raa.lkml@gmail.com>
---

2009/5/11 Johannes Schindelin <Johannes.Schindelin@gmx.de>:
>
> Maybe you can turn this into a patch adding a test (with
> test_expect_failure to mark it as a bug)?  This would make debugging a lot
> easier, as a non-installed Git could be tested.

Here.

 t/t6020-merge-df.sh |   23 +++++++++++++++++++++++
 1 files changed, 23 insertions(+), 0 deletions(-)

diff --git a/t/t6020-merge-df.sh b/t/t6020-merge-df.sh
index a19d49d..b62b52a 100755
--- a/t/t6020-merge-df.sh
+++ b/t/t6020-merge-df.sh
@@ -22,4 +22,27 @@ git commit -m "File: dir"'

 test_expect_code 1 'Merge with d/f conflicts' 'git merge "merge msg" B master'

+test_expect_failure 'F/D conflict' '
+	git reset --hard &&
+	git checkout master &&
+	rm .git/index &&
+
+	mkdir before &&
+	echo FILE >before/one &&
+	echo FILE >after &&
+	git add . &&
+	git commit -mfirst &&
+
+	rm -f after &&
+	git mv before after &&
+	git commit -mmove &&
+
+	git checkout -b para HEAD^ &&
+	echo COMPLETELY ANOTHER FILE >another &&
+	git add . &&
+	git commit -mpara &&
+
+	git merge master
+'
+
 test_done
-- 
1.6.3.28.ga852b

[-- Attachment #2: 0001-Add-a-reminder-test-case-for-a-merge-with-F-D-transi.txt --]
[-- Type: text/plain, Size: 1459 bytes --]

From 05433a6f896c40e4a039815d86613d7e351ef0da Mon Sep 17 00:00:00 2001
From: Alex Riesen <raa.lkml@gmail.com>
Date: Mon, 11 May 2009 11:31:42 +0200
Subject: [PATCH] Add a reminder test case for a merge with F/D transition

The problem is that if a file was replaced with a directory containing
another file with the same content and mode, an attempt to merge it
with a branch descended from a commit before this F->D transition will
cause merge-recursive to break. It breaks even if there were no
conflicting changes on that other branch.

Originally reported by Anders Melchiorsen.

Signed-off-by: Alex Riesen <raa.lkml@gmail.com>
---
 t/t6020-merge-df.sh |   23 +++++++++++++++++++++++
 1 files changed, 23 insertions(+), 0 deletions(-)

diff --git a/t/t6020-merge-df.sh b/t/t6020-merge-df.sh
index a19d49d..b62b52a 100755
--- a/t/t6020-merge-df.sh
+++ b/t/t6020-merge-df.sh
@@ -22,4 +22,27 @@ git commit -m "File: dir"'
 
 test_expect_code 1 'Merge with d/f conflicts' 'git merge "merge msg" B master'
 
+test_expect_failure 'F/D conflict' '
+	git reset --hard &&
+	git checkout master &&
+	rm .git/index &&
+
+	mkdir before &&
+	echo FILE >before/one &&
+	echo FILE >after &&
+	git add . &&
+	git commit -mfirst &&
+
+	rm -f after &&
+	git mv before after &&
+	git commit -mmove &&
+
+	git checkout -b para HEAD^ &&
+	echo COMPLETELY ANOTHER FILE >another &&
+	git add . &&
+	git commit -mpara &&
+
+	git merge master
+'
+
 test_done
-- 
1.6.3.28.ga852b


             reply	other threads:[~2009-05-11  9:42 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-11  9:42 Alex Riesen [this message]
2009-05-11 19:25 ` [PATCH] Fix for a merge where a branch has an F->D transition Alex Riesen
2009-05-13  6:19   ` Junio C Hamano
2009-05-13  6:38     ` Alex Riesen
2009-05-13  9:59       ` Johannes Schindelin
2009-05-13 11:33         ` Alex Riesen
2009-05-20 10:34   ` Johannes Schindelin
2009-05-20 22:09     ` Alex Riesen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=81b0412b0905110242u3624f0eeyc0dc9b2b987bfa2b@mail.gmail.com \
    --to=raa.lkml@gmail.com \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=mail@cup.kalibalik.dk \
    --cc=sam@rfc1149.net \
    --cc=szeder@ira.uka.de \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).