From: Alex Riesen <raa.lkml@gmail.com>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: git@vger.kernel.org, Johannes Sixt <j.sixt@viscovery.net>,
Dmitry Potapov <dpotapov@gmail.com>,
Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH] Expand the rename(2) workaround in mingw to cover case change in filename
Date: Tue, 9 Jun 2009 00:08:09 +0200 [thread overview]
Message-ID: <81b0412b0906081508v5435c59cm3faf3ac92a56578c@mail.gmail.com> (raw)
In-Reply-To: <alpine.DEB.1.00.0906082355350.26154@pacific.mpi-cbg.de>
2009/6/8 Johannes Schindelin <Johannes.Schindelin@gmx.de>:
> On Mon, 8 Jun 2009, Alex Riesen wrote:
>> NOT TESTED. Can't. My Windows broke again. Not even compile-tested.
>
> Yes, that is pretty easy to see as you first used pold/pnew and then
> src/dst.
Yep.
> I minimally fixed up your patch (it now uses strbuf), and added a
> test-case.
>
> This test-case is actually crucial: it shows that your patch is not
> enough: the culprit is this code in builtin-mv.c:167--168:
>
> else if (lstat(dst, &st) == 0) {
> bad = "destination exists";
Ah, thanks. Missed that completely.
next prev parent reply other threads:[~2009-06-08 22:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-08 20:32 [PATCH] Expand the rename(2) workaround in mingw to cover case change in filename Alex Riesen
2009-06-08 21:59 ` Johannes Schindelin
2009-06-08 22:00 ` Johannes Schindelin
2009-06-08 22:08 ` Alex Riesen [this message]
2009-06-09 5:54 ` Johannes Sixt
2009-06-09 6:04 ` Alex Riesen
2009-06-09 7:27 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=81b0412b0906081508v5435c59cm3faf3ac92a56578c@mail.gmail.com \
--to=raa.lkml@gmail.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=dpotapov@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=j.sixt@viscovery.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).