From: Alex Riesen <raa.lkml@gmail.com>
To: Jim Meyering <jim@meyering.net>
Cc: git list <git@vger.kernel.org>
Subject: Re: [PATCH] use xstrdup, not strdup in ll-merge.c
Date: Mon, 15 Jun 2009 00:03:27 +0200 [thread overview]
Message-ID: <81b0412b0906141503v14484d9fyea56198910305bfc@mail.gmail.com> (raw)
In-Reply-To: <87bpoqoavp.fsf@meyering.net>
2009/6/14 Jim Meyering <jim@meyering.net>:
> @@ -231,7 +231,7 @@ static int read_merge_config(const char *var, const char *value, void *cb)
>
> if (!strcmp(var, "merge.default")) {
> if (value)
> - default_ll_merge = strdup(value);
> + default_ll_merge = xstrdup(value);
read_merge_config has a failure mode (where it returns -1), why not use it?
next prev parent reply other threads:[~2009-06-14 22:03 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-14 19:47 [PATCH] use xstrdup, not strdup in ll-merge.c Jim Meyering
2009-06-14 22:03 ` Alex Riesen [this message]
2009-06-15 8:02 ` Jim Meyering
2009-06-15 8:45 ` Alex Riesen
2009-06-15 9:23 ` Jim Meyering
2009-06-15 11:39 ` Alex Riesen
2009-06-15 11:49 ` Jim Meyering
2009-06-15 12:46 ` Alex Riesen
2009-06-15 14:26 ` Shawn O. Pearce
2009-06-15 15:21 ` Alex Riesen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=81b0412b0906141503v14484d9fyea56198910305bfc@mail.gmail.com \
--to=raa.lkml@gmail.com \
--cc=git@vger.kernel.org \
--cc=jim@meyering.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).