From: Alex Riesen <raa.lkml@gmail.com>
To: Johan Herland <johan@herland.net>
Cc: Johannes Sixt <j.sixt@viscovery.net>,
Junio C Hamano <gitster@pobox.com>,
git@vger.kernel.org, Peter Krefting <peter@softwolves.pp.se>,
"Shawn O. Pearce" <spearce@spearce.org>
Subject: Re: [PATCH] quickfetch(): Prevent overflow of the rev-list command line
Date: Thu, 9 Jul 2009 10:01:45 +0200 [thread overview]
Message-ID: <81b0412b0907090101x7c8aa182o36687d67be3c5fb0@mail.gmail.com> (raw)
In-Reply-To: <200907081801.36901.johan@herland.net>
On Wed, Jul 8, 2009 at 18:01, Johan Herland<johan@herland.net> wrote:
> On Wednesday 08 July 2009, Johannes Sixt wrote:
>> ... don't you get this error message with errno set to EPIPE?
>> Previously, there was no error message.
>
> Indeed, you are correct. I guess the following should be added to the
> patch:
>
> if (write_in_full(revlist.in, sha1_to_hex(ref->old_sha1), 40) < 0 ||
> write_in_full(revlist.in, "\n", 1) < 0) {
> - error("failed write to rev-list");
> - err = errno;
> + if (errno != EPIPE) {
> + error("failed write to rev-list");
> + err = errno;
You'll loose errno this way: error() does not save it.
next prev parent reply other threads:[~2009-07-09 8:01 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-18 13:10 msysgit git-submodule: "Unable to fetch in submodule path ..." Peter Krefting
2009-06-22 12:46 ` Peter Krefting
2009-07-08 13:58 ` [PATCH] quickfetch(): Prevent overflow of the rev-list command line Johan Herland
2009-07-08 15:12 ` Johannes Sixt
2009-07-08 16:01 ` Johan Herland
2009-07-08 17:22 ` Junio C Hamano
2009-07-09 8:43 ` Johan Herland
2009-07-09 8:49 ` Alex Riesen
2009-07-09 8:51 ` Johannes Sixt
2009-07-09 9:07 ` Johan Herland
2009-07-09 9:15 ` Johannes Sixt
2009-07-09 9:34 ` Johan Herland
2009-07-09 12:22 ` Johannes Sixt
2009-07-09 13:52 ` [PATCH v3] " Johan Herland
2009-07-09 14:21 ` Johannes Sixt
2009-07-09 14:32 ` Jeff King
2009-07-09 14:49 ` [PATCH v4] " Johan Herland
2009-07-09 16:20 ` Johannes Sixt
2009-07-09 23:52 ` [PATCH v5] " Johan Herland
2009-07-11 6:55 ` Junio C Hamano
2009-07-11 10:58 ` Johan Herland
2009-07-09 14:42 ` [PATCH v3] " Johan Herland
2009-07-09 14:56 ` Johannes Sixt
2009-07-09 15:32 ` Johan Herland
2009-07-09 16:14 ` Johannes Sixt
2009-07-09 8:01 ` Alex Riesen [this message]
2009-07-09 8:37 ` [PATCH] " Johan Herland
2009-07-09 8:43 ` Alex Riesen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=81b0412b0907090101x7c8aa182o36687d67be3c5fb0@mail.gmail.com \
--to=raa.lkml@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=j.sixt@viscovery.net \
--cc=johan@herland.net \
--cc=peter@softwolves.pp.se \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).