From: Alex Riesen <raa.lkml@gmail.com>
To: Thomas Rast <trast@student.ethz.ch>
Cc: Eugene Sajine <euguess@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH] describe: when failing, tell the user about options that work
Date: Thu, 22 Oct 2009 18:40:33 +0200 [thread overview]
Message-ID: <81b0412b0910220940n78ddb774i30338147327b198a@mail.gmail.com> (raw)
In-Reply-To: <f1e86b9095d63c6541d0a8df6a1cf8eadfe247bb.1256226187.git.trast@student.ethz.ch>
On Thu, Oct 22, 2009 at 17:44, Thomas Rast <trast@student.ethz.ch> wrote:
> @@ -259,7 +260,14 @@ static void describe(const char *arg, int last_one)
> printf("%s\n", find_unique_abbrev(sha1, abbrev));
> return;
> }
> - die("cannot describe '%s'", sha1_to_hex(sha1));
> + if (unannotated_cnt)
> + die("cannot describe '%s'"
> + " with only\nannotated tags. Try --tags.",
> + sha1_to_hex(sha1));
> + else
> + die("cannot describe '%s'"
> + " with tags\nTry --always, or create some tags.",
> + sha1_to_hex(sha1));
These are quite verbose. Could they be conditional on something like
advice.describeHints?
next prev parent reply other threads:[~2009-10-22 16:48 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-22 14:47 git describe is failing Eugene Sajine
2009-10-22 14:59 ` Mikael Magnusson
2009-10-22 15:02 ` Thomas Rast
2009-10-22 15:10 ` Eugene Sajine
2009-10-22 15:44 ` [PATCH] describe: when failing, tell the user about options that work Thomas Rast
2009-10-22 16:40 ` Alex Riesen [this message]
2009-10-22 22:26 ` Junio C Hamano
2009-10-23 0:13 ` Nicolas Pitre
2009-10-23 0:28 ` Junio C Hamano
2009-10-23 0:25 ` Junio C Hamano
2009-10-23 8:34 ` Thomas Rast
2009-10-23 18:57 ` Junio C Hamano
2009-10-28 22:10 ` [PATCH v2] " Thomas Rast
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=81b0412b0910220940n78ddb774i30338147327b198a@mail.gmail.com \
--to=raa.lkml@gmail.com \
--cc=euguess@gmail.com \
--cc=git@vger.kernel.org \
--cc=trast@student.ethz.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).