From: Alex Riesen <raa.lkml@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Pat Thoyts <patthoyts@users.sourceforge.net>,
Johannes Sixt <j.sixt@viscovery.net>,
"Murphy, John" <john.murphy@bankofamerica.com>,
Paul Mackerras <paulus@samba.org>,
git@vger.kernel.org
Subject: Re: [PATCH] Re: Gitk --all error when there are more than 797 refs in a repository
Date: Tue, 3 Nov 2009 11:04:44 +0100 [thread overview]
Message-ID: <81b0412b0911030204v46adf54gb9ed65e78ce2b6df@mail.gmail.com> (raw)
In-Reply-To: <7v1vlzvjtg.fsf@alter.siamese.dyndns.org>
On Tue, Sep 22, 2009 at 02:39, Junio C Hamano <gitster@pobox.com> wrote:
> Pat Thoyts <patthoyts@users.sourceforge.net> writes:
>> if {$revs eq {}} {
>> set revs HEAD
>> + } elseif {$revs eq "--all"} {
>> + return $revs
>> }
>
> That looks like an ugly hack (aka sweeping the issue under the rug).
>
And it is a race condition. By the time git log has got --all list of references
it may look completely different to what gitk has.
next prev parent reply other threads:[~2009-11-03 10:04 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-17 19:07 Gitk --all error when there are more than 797 refs in a repository Murphy, John
2009-09-18 14:06 ` [PATCH] " Pat Thoyts
2009-09-18 15:16 ` Johannes Sixt
2009-09-19 0:07 ` Paul Mackerras
2009-09-21 14:02 ` Murphy, John
2009-09-21 14:09 ` Johannes Sixt
2009-09-21 14:11 ` Murphy, John
2009-09-21 15:59 ` Johannes Sixt
2009-09-21 23:56 ` Pat Thoyts
2009-09-22 1:23 ` Murphy, John
2009-09-22 1:39 ` Junio C Hamano
2009-09-22 1:47 ` Junio C Hamano
2009-09-22 22:48 ` Pat Thoyts
2009-11-03 10:04 ` Alex Riesen [this message]
2009-11-03 10:41 ` Paul Mackerras
2009-09-22 23:30 ` Paul Mackerras
2009-09-23 0:02 ` Junio C Hamano
2009-11-03 9:40 ` Paul Mackerras
2009-11-03 14:59 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=81b0412b0911030204v46adf54gb9ed65e78ce2b6df@mail.gmail.com \
--to=raa.lkml@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=j.sixt@viscovery.net \
--cc=john.murphy@bankofamerica.com \
--cc=patthoyts@users.sourceforge.net \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).