From: Michael Witten <mfwitten@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Huynh Khoi Nguyen Nguyen
<Huynh-Khoi-Nguyen.Nguyen@ensimag.imag.fr>,
git@vger.kernel.org
Subject: [PATCH 0/3] Testing: XDG config files: Fix broken tests
Date: Tue, 17 Jul 2012 17:25:49 -0000 [thread overview]
Message-ID: <82316e5034d940e09fed719ae7bfdc3b-mfwitten@gmail.com> (raw)
The tests for the new XDG config file code are broken because the
environoment variable `XDG_CONFIG_HOME' is never set properly,
and the tests themselves do not use `XDG_CONFIG_HOME' or `HOME'
explicitly.
The following patch series corrects this brittleness (and the
failures to which it has led):
t/t1306-xdg-files.sh | 69 +++++++++++++++++++++++++++-------------------------
t/test-lib.sh | 3 +++
2 files changed, 39 insertions(+), 33 deletions(-)
[1] Export a suitable `XDG_CONFIG_HOME' environment variable
[2] Use "$HOME" and "$XDG_CONFIG_HOME" explicitly
[3] Trivial: `xdg' -> `XDG'
--
1.7.11.1.29.gf71be5c
next reply other threads:[~2012-07-17 17:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-17 17:25 Michael Witten [this message]
2012-07-17 16:41 ` [PATCH 1/3] Testing: XDG config files: Export a suitable `XDG_CONFIG_HOME' environment variable Michael Witten
2012-07-17 17:57 ` Jonathan Nieder
2012-07-17 18:14 ` Matthieu Moy
2012-07-17 18:31 ` Junio C Hamano
2012-07-17 16:41 ` [PATCH 2/3] Testing: XDG config files: Use "$HOME" and "$XDG_CONFIG_HOME" explicitly Michael Witten
2012-07-17 18:19 ` Matthieu Moy
2012-07-17 16:41 ` [PATCH 3/3] Testing: XDG config files: Trivial: `xdg' -> `XDG' Michael Witten
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=82316e5034d940e09fed719ae7bfdc3b-mfwitten@gmail.com \
--to=mfwitten@gmail.com \
--cc=Huynh-Khoi-Nguyen.Nguyen@ensimag.imag.fr \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).