git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Lars Schneider <larsxschneider@gmail.com>
To: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>
Cc: Antoine Queru <antoine.queru@ensimag.grenoble-inp.fr>,
	Remi Galan Alfonso <remi.galan-alfonso@ensimag.grenoble-inp.fr>,
	Antoine Queru <Antoine.Queru@grenoble-inp.org>,
	git@vger.kernel.org,
	william duclot <william.duclot@ensimag.grenoble-inp.fr>,
	simon rabourg <simon.rabourg@ensimag.grenoble-inp.fr>,
	francois beutin <francois.beutin@ensimag.grenoble-inp.fr>,
	rsbecker@nexbridge.com, aaron@schrab.com, peff@peff.net
Subject: Re: [RFC/PATCH] push: deny policy to prevent pushes to unwanted remotes.
Date: Tue, 21 Jun 2016 09:45:45 +0200	[thread overview]
Message-ID: <827DA549-F046-4B52-90C2-ADB5BC72C16F@gmail.com> (raw)
In-Reply-To: <vpqfus7jc59.fsf@anie.imag.fr>


> On 21 Jun 2016, at 08:20, Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> wrote:
> 
> Antoine Queru <antoine.queru@ensimag.grenoble-inp.fr> writes:
> 
>> However, in the last version, if we want to deny an website,
>> including all schemes, we can blacklist the url without the
>> scheme. For example, "pushBlacklist = github.com". By doing so, this
>> remote is not an url anymore, and it can't be differenced with a local
>> relative path. It's a problem because these two have a different
>> treatement. The choice we made to solve this is to force the user to
>> put the scheme "file://" before any local relative path. What do you
>> think ?
> 
> file:// URL can not be relative (well, you can invent a syntax where
> they are, but that would be weird).
> 
> I think you can just forbid relative path in whitelist/blacklist, hence
> consider that anything that is neither a full URL nor an absolute path
> is a protocol-less URL:
> 
> * http://github.com = github.com with HTTP protocol
> 
> * github.com = github.com with any protocol
> 
> * /path/to/file or file:///path/to/file = local path

I agree. Ignoring relative paths (and mentioning that in the docs)
sounds reasonable to me. I don't think that would be a limitation as
I can't think of a white/blacklist use case for relative URLs.

Thanks,
Lars

  reply	other threads:[~2016-06-21  7:46 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-04 14:51 [RFC/PATCH] push: deny policy to prevent pushes to unwanted remotes Antoine Queru
2016-06-06 11:39 ` Remi Galan Alfonso
2016-06-06 13:43   ` Antoine Queru
2016-06-15 19:37     ` Lars Schneider
2016-06-20 22:25       ` Antoine Queru
2016-06-21  6:20         ` Matthieu Moy
2016-06-21  7:45           ` Lars Schneider [this message]
2016-06-06 15:18 ` Matthieu Moy
2016-06-06 16:13   ` Junio C Hamano
2016-06-06 16:37   ` Matthieu Moy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=827DA549-F046-4B52-90C2-ADB5BC72C16F@gmail.com \
    --to=larsxschneider@gmail.com \
    --cc=Antoine.Queru@grenoble-inp.org \
    --cc=Matthieu.Moy@grenoble-inp.fr \
    --cc=aaron@schrab.com \
    --cc=antoine.queru@ensimag.grenoble-inp.fr \
    --cc=francois.beutin@ensimag.grenoble-inp.fr \
    --cc=git@vger.kernel.org \
    --cc=peff@peff.net \
    --cc=remi.galan-alfonso@ensimag.grenoble-inp.fr \
    --cc=rsbecker@nexbridge.com \
    --cc=simon.rabourg@ensimag.grenoble-inp.fr \
    --cc=william.duclot@ensimag.grenoble-inp.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).