Re: [PATCH v3 0/1] move excludes_file into repo_config_values

[Tian Yuchen <cat@malon.dev>]

On 6/27/26 23:45, Tian Yuchen wrote:
> This patch continues the libification effort by migrating the global
> string variable 'excludes_file' into 'struct repo_config_values'. Since
> this is a dynamically allocated variable, the migration requires proper
> heap memory management.
> 
> This patch mainly does three things:
> 
>   - Abstract the XDG fallback lazy-loading logic out of dir.c into a proper
>   getter.
> 
>   - Move the variables into the struct repo_config_values.
> 
>   - Introduce the memory destructor 'repo_config_values_clear()'.
> 
> 
> Changes since V2:
> 
>   - Squash together the previous two commits into one.
> 
>   - The 'repo->initialized' check is used in both the getter and destructor.
>   This eliminates redundant checks and follows the fail-fast principle. This
>   is consistent with the previous global variable removal patches [1][2][3].
> 
> Thanks!
> 
> Mentored-by: Christian Couder <christian.couder@gmail.com>
> Mentored-by: Ayush Chandekar <ayu.chandekar@gmail.com>
> Mentored-by: Olamide Caleb Bello <belkid98@gmail.com>
> Signed-off-by: Tian Yuchen <cat@malon.dev>
> 
> [1] https://lore.kernel.org/git/20260610093635.139719-1-cat@malon.dev/T/#m856253610936d052a798259bfc06d598561e53c4
> [2] https://lore.kernel.org/git/20260606143412.15443-1-cat@malon.dev/
> [3] https://lore.kernel.org/git/20260617154929.564498-2-cat@malon.dev/T/#m8843984a6175a1a4c7e00877085c77b0c72f5803
> 
> Tian Yuchen (1):
>    environment: move excludes_file into repo_config_values
> 
>   dir.c         |  4 ++--
>   environment.c | 30 +++++++++++++++++++++++++++---
>   environment.h | 13 ++++++++++++-
>   repository.c  |  1 +
>   4 files changed, 42 insertions(+), 6 deletions(-)
> 

What happened...? I used in-reply-to this time, but I probably typed too 
fast and didn't notice where I made a mistake. Anyway...

https://lore.kernel.org/git/20260626075037.532164-1-cat@malon.dev/#t

This is the link to the previous patch. Hopefully it will be helpful...

Apology, yuchen