From: Anton Gyllenberg <anton@iki.fi>
To: Eric Wong <normalperson@yhbt.net>
Cc: git@vger.kernel.org, gitster@pobox.com
Subject: Re: [PATCH] git-svn: fix broken symlink workaround when switching branches
Date: Wed, 11 Feb 2009 19:44:09 +0200 [thread overview]
Message-ID: <83dfc36c0902110944n57502fb6jc2ae5cf79bd4276b@mail.gmail.com> (raw)
In-Reply-To: <20090211101207.GA28840@dcvr.yhbt.net>
On Wed, Feb 11, 2009 at 12:12 PM, Eric Wong <normalperson@yhbt.net> wrote:
> Thanks Anton, I've made the following patch along with your
> testcase and pushed to git://git.bogomips.org/git-svn
>
> Can you let me know if it works on a real repo (or breaks anything
> else)? It's once again way past my bed time...
>
> git-svn.perl | 11 ++++++-----
> 1 files changed, 6 insertions(+), 5 deletions(-)
I checked out that version and it works perfectly on the real repo I
initially noticed the problem on. The end results are identical to
git-svn from v1.6.0.4 (predates the symlink scan) when fetching 2000+
revisions spanning the problematic branch messup. Works and did not
break anything for me.
Thank you for your work on git-svn!
Anton
next prev parent reply other threads:[~2009-02-11 17:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-10 22:38 [PATCH] test case for regression caused by git-svn empty symlink fix Anton Gyllenberg
2009-02-11 10:12 ` [PATCH] git-svn: fix broken symlink workaround when switching branches Eric Wong
2009-02-11 17:44 ` Anton Gyllenberg [this message]
2009-02-11 18:41 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83dfc36c0902110944n57502fb6jc2ae5cf79bd4276b@mail.gmail.com \
--to=anton@iki.fi \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=normalperson@yhbt.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).