Git development
 help / color / mirror / Atom feed
From: Tian Yuchen <a3205153416@gmail.com>
To: Trieu Huynh <vikingtc4@gmail.com>, git@vger.kernel.org
Subject: Re: [GSoC PATCH] promisor-remote: fix promisor.quiet to use the correct repository
Date: Thu, 9 Apr 2026 01:53:29 +0800	[thread overview]
Message-ID: <84ca1cfa-a8b8-4426-b610-c9bc24843c25@gmail.com> (raw)
In-Reply-To: <20260406183041.783800-1-vikingtc4@gmail.com>

On 4/7/26 02:30, Trieu Huynh wrote:

I strongly recommend you to run a patch locally before sending it.

	 not ok 38 - promisor.quiet from submodule repo is honored

> +test_expect_success 'promisor.quiet from submodule repo is honored' '
> +	rm -f pc-quiet-trace &&
> +
> +	# Set promisor.quiet only in the submodule, not the superproject.
> +	git -C super-work/sub config promisor.quiet true &&
> +
> +	# Push a new commit+blob to the server; the blob stays missing in the
> +	# partial-clone submodule until a lazy fetch is triggered.
> +	test_commit -C sub-pc-src updated new-file.txt "world" &&
> +	git -C sub-pc-src push "$(pwd)/sub-pc-srv.bare" HEAD:master &&
> +	git -C super-work/sub -c protocol.file.allow=always fetch origin &&
> +	git -C super-work/sub reset --mixed origin/master &&
> +
> +	# grep descends into the submodule and triggers a lazy fetch for the
> +	# missing blob; verify the fetch subprocess carries --quiet.
> +	GIT_TRACE2_EVENT="$(pwd)/pc-quiet-trace" \
> +		git -C super-work grep --cached --recurse-submodules "world" \
> +		2>/dev/null &&
> +	grep negotiationAlgorithm pc-quiet-trace | grep -e --quiet
> +'
> +
>   . "$TEST_DIRECTORY"/lib-httpd.sh
>   start_httpd
>   

Regards, Yuchen

      parent reply	other threads:[~2026-04-08 17:53 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-06 18:30 [GSoC PATCH] promisor-remote: fix promisor.quiet to use the correct repository Trieu Huynh
2026-04-08 17:48 ` Tian Yuchen
2026-04-08 18:23   ` Junio C Hamano
2026-04-09  4:34     ` Tian Yuchen
2026-04-13 18:22       ` Trieu Huynh
2026-04-15 17:39         ` Junio C Hamano
2026-04-15 18:03           ` Tian Yuchen
2026-04-08 17:53 ` Tian Yuchen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=84ca1cfa-a8b8-4426-b610-c9bc24843c25@gmail.com \
    --to=a3205153416@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=vikingtc4@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox