From: David Turner <David.Turner@twosigma.com>
To: 'Jeff King' <peff@peff.net>
Cc: "git@vger.kernel.org" <git@vger.kernel.org>
Subject: RE: [PATCH] pack-objects: don't warn about bitmaps on incremental pack
Date: Mon, 19 Dec 2016 16:03:09 +0000 [thread overview]
Message-ID: <84da83e80fff40e3b7de43d2a11d440d@exmbdft7.ad.twosigma.com> (raw)
In-Reply-To: <20161217040426.7qeixbihiou5mbsl@sigill.intra.peff.net>
> diff --git a/builtin/gc.c b/builtin/gc.c index 069950d0b4..d3c978c765
> 100644
> --- a/builtin/gc.c
> +++ b/builtin/gc.c
> @@ -191,6 +191,11 @@ static void add_repack_all_option(void)
> }
> }
>
> +static void add_repack_incremental_option(void)
> +{
> + argv_array_push(&repack, "--no-write-bitmap-index"); }
> +
> static int need_to_gc(void)
> {
> /*
> @@ -208,7 +213,9 @@ static int need_to_gc(void)
> */
> if (too_many_packs())
> add_repack_all_option();
> - else if (!too_many_loose_objects())
> + else if (too_many_loose_objects())
> + add_repack_incremental_option();
> + else
> return 0;
>
> if (run_hook_le(NULL, "pre-auto-gc", NULL))
Sure, that's fine.
next prev parent reply other threads:[~2016-12-19 16:04 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-16 21:05 "disabling bitmap writing, as some objects are not being packed"? David Turner
2016-12-16 21:27 ` Jeff King
2016-12-16 21:28 ` Junio C Hamano
2016-12-16 21:32 ` Jeff King
2016-12-16 21:40 ` David Turner
2016-12-16 21:49 ` Jeff King
2016-12-16 23:59 ` [PATCH] pack-objects: don't warn about bitmaps on incremental pack David Turner
2016-12-17 4:04 ` Jeff King
2016-12-19 16:03 ` David Turner [this message]
2016-12-17 7:50 ` "disabling bitmap writing, as some objects are not being packed"? Duy Nguyen
2017-02-08 1:03 ` David Turner
2017-02-08 6:45 ` Duy Nguyen
2017-02-08 8:24 ` David Turner
2017-02-08 8:37 ` Duy Nguyen
2017-02-08 17:44 ` Junio C Hamano
2017-02-08 19:05 ` David Turner
2017-02-08 19:08 ` Jeff King
2017-02-08 22:14 ` David Turner
2017-02-08 23:00 ` Jeff King
2017-02-09 0:18 ` Junio C Hamano
2017-02-09 1:12 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=84da83e80fff40e3b7de43d2a11d440d@exmbdft7.ad.twosigma.com \
--to=david.turner@twosigma.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).