From: Constantine Plotnikov <constantine.plotnikov@gmail.com>
To: Sverre Rabbelier <srabbelier@gmail.com>, git@vger.kernel.org
Subject: [JGIT PATCH v2] Fixed QuotedStringGitPathStyleTest.testDequote_OctalAll test that generated incorrect UTF-8 escape sequences
Date: Mon, 16 Feb 2009 21:50:21 +0300 [thread overview]
Message-ID: <85647ef50902161050i43b478d4kb7faaa211dee727d@mail.gmail.com> (raw)
The test was failing on the system that use a encoding different
from ISO-8859-1. The reason was that invalid UTF-8 bytes were
generated for codepoints greater than U+7F, and in this case
the method RawParseUtils.decodeNoFallback falls backs to the
default system encoding.
Signed-off-by: Constantine Plotnikov <Constantine.Plotnikov@jetbrains.com>
---
The bug was causing failure for the maven build on the windows
environment that uses Cp1251 as a system encoding. However the test
worked from Eclipse until I have specified jvm option
-Dfile.ecoding=Cp1251, in the test case started to fail in Eclipse as
well.
.../jgit/util/QuotedStringGitPathStyleTest.java | 21 ++++++++++++++-----
1 files changed, 15 insertions(+), 6 deletions(-)
diff --git a/org.spearce.jgit.test/tst/org/spearce/jgit/util/QuotedStringGitPathStyleTest.java
b/org.spearce.jgit.test/tst/org/spearce/jgit/util/QuotedStringGitPathStyleTest.java
index 54fbd31..7d29f21 100644
--- a/org.spearce.jgit.test/tst/org/spearce/jgit/util/QuotedStringGitPathStyleTest.java
+++ b/org.spearce.jgit.test/tst/org/spearce/jgit/util/QuotedStringGitPathStyleTest.java
@@ -127,13 +127,22 @@ public void testDequote_NamedEscapes() {
}
public void testDequote_OctalAll() {
- for (int i = 0; i < 256; i++) {
- String s = Integer.toOctalString(i);
- while (s.length() < 3) {
- s = "0" + s;
- }
- assertDequote("" + (char) i, "\\" + s);
+ for (int i = 0; i < 127; i++) {
+ assertDequote("" + (char) i, octalEscape(i));
}
+ for (int i = 128; i < 256; i++) {
+ int f = 0xC0 | (i >> 6);
+ int s = 0x80 | (i & 0x3f);
+ assertDequote("" + (char) i, octalEscape(f)+octalEscape(s));
+ }
+ }
+
+ private String octalEscape(int i) {
+ String s = Integer.toOctalString(i);
+ while (s.length() < 3) {
+ s = "0" + s;
+ }
+ return "\\"+s;
}
public void testQuote_OctalAll() {
--
1.6.1.2
next reply other threads:[~2009-02-16 18:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-16 18:50 Constantine Plotnikov [this message]
2009-02-18 15:46 ` [JGIT PATCH v2] Fixed QuotedStringGitPathStyleTest.testDequote_OctalAll test that generated incorrect UTF-8 escape sequences Shawn O. Pearce
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=85647ef50902161050i43b478d4kb7faaa211dee727d@mail.gmail.com \
--to=constantine.plotnikov@gmail.com \
--cc=git@vger.kernel.org \
--cc=srabbelier@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).