From: "René Scharfe" <l.s.r@web.de>
To: Junio C Hamano <gitster@pobox.com>
Cc: "Johannes Sixt" <j6t@kdbg.org>,
"Torsten Bögershausen" <tboegi@web.de>,
"Peter Krefting" <peter@softwolves.pp.se>,
git@vger.kernel.org,
"Keith Goldfarb" <keith@blackthorn-media.com>
Subject: Re: [PATCH v3 0/5] archive-zip: support files and archives bigger than 4GB
Date: Mon, 1 May 2017 10:30:04 +0200 [thread overview]
Message-ID: <85744f48-c408-4fc7-bdf1-1e3961703dd0@web.de> (raw)
In-Reply-To: <xmqqfugplamn.fsf@gitster.mtv.corp.google.com>
Am 01.05.2017 um 01:49 schrieb Junio C Hamano:
> René Scharfe <l.s.r@web.de> writes:
>
>> Am 30.04.2017 um 18:32 schrieb Johannes Sixt:
>>> Am 30.04.2017 um 09:53 schrieb René Scharfe:
>>>> @@ -178,7 +182,8 @@ test_expect_success EXPENSIVE,UNZIP 'zip
>>>> archive bigger than 4GB' '
>>>> "$GIT_UNZIP" -t many-big.zip
>>>> '
>>>>
>>>> -test_expect_success EXPENSIVE,UNZIP,ZIPINFO 'zip archive with
>>>> files bigger than 4GB' '
>>>> +test_expect_success
>>>> EXPENSIVE,LONG_IS_64BIT,UNZIP,UNZIP_ZIP64_SUPPORT,ZIPINFO \
>>>
>>> Why is LONG_IS_64BIT required?
>>
>> Blob sizes are kept in variables of type unsigned long. 64 bits are
>> required to store file sizes bigger than 4GB, and this test is about
>> such a file. A 32-bit git can't use the pack we supply the test file
>> in, so we have to skip this test.
>>
>>>> + 'zip archive with files bigger than 4GB' '
>>>> # Pack created with:
>>>> # dd if=/dev/zero of=file bs=1M count=4100 && git
>>>> hash-object -w file
>>>> mkdir -p .git/objects/pack &&
>
> OK, so let's queue this on top and have it in 'next' to unblock
> users of older unzip and unzip compiled wihtout zip64 support?
Yes, please; it allows them to run t5004 with --long-tests or
GIT_TEST_LONG set (but not to actually test zip64 functionality).
René
next prev parent reply other threads:[~2017-05-01 8:30 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-21 21:08 Git archive doesn't fully support zip64 Keith Goldfarb
2017-04-22 19:22 ` [PATCH] archive-zip: Add zip64 headers when file size is too large for 32 bits Peter Krefting
2017-04-22 21:52 ` Johannes Sixt
2017-04-22 22:41 ` [PATCH v2] " Peter Krefting
2017-04-23 7:50 ` Johannes Sixt
2017-04-23 14:51 ` Peter Krefting
2017-04-23 19:49 ` Johannes Sixt
2017-04-24 8:04 ` Peter Krefting
2017-04-24 12:04 ` René Scharfe
2017-04-24 17:22 ` [PATCH v3 0/5] archive-zip: support files and archives bigger than 4GB René Scharfe
2017-04-24 17:29 ` [PATCH v3 1/5] archive-zip: add tests for big ZIP archives René Scharfe
2017-04-24 17:30 ` [PATCH v3 2/5] archive-zip: use strbuf for ZIP directory René Scharfe
2017-04-25 4:51 ` Junio C Hamano
2017-04-25 5:28 ` René Scharfe
2017-04-24 17:31 ` [PATCH v3 3/5] archive-zip: write ZIP dir entry directly to strbuf René Scharfe
2017-04-24 17:32 ` [PATCH v3 4/5] archive-zip: support archives bigger than 4GB René Scharfe
2017-04-24 18:24 ` Peter Krefting
2017-04-24 20:06 ` René Scharfe
2017-04-24 20:39 ` René Scharfe
2017-04-24 21:02 ` Johannes Sixt
2017-04-24 21:41 ` René Scharfe
2017-04-25 7:55 ` Peter Krefting
2017-04-25 16:24 ` René Scharfe
2017-04-26 21:02 ` Peter Krefting
2017-04-26 23:38 ` René Scharfe
2017-04-27 4:57 ` Peter Krefting
2017-04-27 19:54 ` René Scharfe
2017-04-28 8:40 ` Peter Krefting
2017-04-24 17:33 ` [PATCH v3 5/5] archive-zip: support files " René Scharfe
2017-04-24 21:11 ` Keith Goldfarb
2017-04-25 4:46 ` Junio C Hamano
2017-04-25 5:27 ` René Scharfe
2017-04-29 21:00 ` [PATCH v3 0/5] archive-zip: support files and archives " Torsten Bögershausen
2017-04-29 22:28 ` René Scharfe
2017-04-30 5:31 ` Torsten Bögershausen
2017-04-30 7:53 ` René Scharfe
2017-04-30 13:06 ` Torsten Bögershausen
2017-04-30 16:32 ` Johannes Sixt
2017-04-30 16:40 ` René Scharfe
2017-04-30 23:49 ` Junio C Hamano
2017-05-01 8:30 ` René Scharfe [this message]
2017-04-23 0:16 ` [PATCH] archive-zip: Add zip64 headers when file size is too large for 32 bits René Scharfe
2017-04-23 6:42 ` Peter Krefting
2017-04-23 7:27 ` Johannes Sixt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=85744f48-c408-4fc7-bdf1-1e3961703dd0@web.de \
--to=l.s.r@web.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=j6t@kdbg.org \
--cc=keith@blackthorn-media.com \
--cc=peter@softwolves.pp.se \
--cc=tboegi@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).