From: "Derrick Stolee via GitGitGadget" <gitgitgadget@gmail.com>
To: git@vger.kernel.org
Cc: peff@peff.net, vdye@github.com, gitster@pobox.com,
Derrick Stolee <derrickstolee@github.com>,
Derrick Stolee <derrickstolee@github.com>
Subject: [PATCH 2/3] bundle-uri: advertise based on repo config
Date: Mon, 12 Dec 2022 17:33:25 +0000 [thread overview]
Message-ID: <857d1abec4cf124e011c7f84276ce105cb5b3a96.1670866407.git.gitgitgadget@gmail.com> (raw)
In-Reply-To: <pull.1443.git.1670866407.gitgitgadget@gmail.com>
From: Derrick Stolee <derrickstolee@github.com>
The bundle_uri_advertise() method was not using its repository
parameter, but this is a mistake. Use repo_config_get_maybe_bool()
instead of git_config_maybe_bool().
Signed-off-by: Derrick Stolee <derrickstolee@github.com>
---
bundle-uri.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/bundle-uri.c b/bundle-uri.c
index 8efb4e7acad..5f158cc52e1 100644
--- a/bundle-uri.c
+++ b/bundle-uri.c
@@ -610,7 +610,7 @@ int bundle_uri_advertise(struct repository *r, struct strbuf *value)
goto cached;
advertise_bundle_uri = 0;
- git_config_get_maybe_bool("uploadpack.advertisebundleuris", &advertise_bundle_uri);
+ repo_config_get_maybe_bool(r, "uploadpack.advertisebundleuris", &advertise_bundle_uri);
cached:
return advertise_bundle_uri;
--
gitgitgadget
next prev parent reply other threads:[~2022-12-12 17:34 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-12 17:33 [PATCH 0/3] Bundle URIs 4.5: fixups from part IV Derrick Stolee via GitGitGadget
2022-12-12 17:33 ` [PATCH 1/3] bundle-uri: drop unused 'uri' parameter Derrick Stolee via GitGitGadget
2022-12-19 10:57 ` Ævar Arnfjörð Bjarmason
2022-12-20 0:49 ` Junio C Hamano
2022-12-20 14:02 ` Derrick Stolee
2022-12-20 20:50 ` Ævar Arnfjörð Bjarmason
2022-12-20 13:57 ` Derrick Stolee
2022-12-20 20:46 ` Ævar Arnfjörð Bjarmason
2022-12-12 17:33 ` Derrick Stolee via GitGitGadget [this message]
2022-12-19 11:04 ` [PATCH 2/3] bundle-uri: advertise based on repo config Ævar Arnfjörð Bjarmason
2022-12-20 13:54 ` Derrick Stolee
2022-12-12 17:33 ` [PATCH 3/3] bundle-uri: remove GIT_TEST_BUNDLE_URI env variable Derrick Stolee via GitGitGadget
2022-12-19 11:09 ` Ævar Arnfjörð Bjarmason
2022-12-20 13:51 ` Derrick Stolee
2022-12-20 20:41 ` Ævar Arnfjörð Bjarmason
2022-12-12 18:07 ` [PATCH 0/3] Bundle URIs 4.5: fixups from part IV Victoria Dye
2022-12-12 20:59 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=857d1abec4cf124e011c7f84276ce105cb5b3a96.1670866407.git.gitgitgadget@gmail.com \
--to=gitgitgadget@gmail.com \
--cc=derrickstolee@github.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
--cc=vdye@github.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).