git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: drafnel@gmail.com
To: git@vger.kernel.org
Cc: gitster@pobox.com, Brandon Casey <drafnel@gmail.com>
Subject: [PATCH 5/5] git-tag: call verify_tag_buffer to validate the generated tag object
Date: Thu,  8 May 2008 21:19:49 -0500	[thread overview]
Message-ID: <859967.1210299539642.JavaMail.teamon@b301.teamon.com> (raw)
In-Reply-To: <1210299589-10448-5-git-send-email-drafnel@example.com>

From: Brandon Casey <drafnel@gmail.com>

This will ensure that both git-tag and git-mktag "produce valid tags,
with the same definition of validity."

Signed-off-by: Brandon Casey <drafnel@gmail.com>
---
 builtin-tag.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/builtin-tag.c b/builtin-tag.c
index 85ec2f3..0f79d47 100644
--- a/builtin-tag.c
+++ b/builtin-tag.c
@@ -508,6 +508,8 @@ static void create_tag(const unsigned char *object, const char *tag,
 
 	if (sign && do_sign(buf) < 0)
 		die("unable to sign the tag");
+	if (verify_tag_buffer(buf->buf, buf->len) < 0)
+		die("invalid tag object");
 	if (write_sha1_file(buf->buf, buf->len, tag_type, result) < 0)
 		die("unable to write tag file");
 }
-- 
1.5.5.67.g9a49

      parent reply	other threads:[~2008-05-09  2:33 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1210299589-10448-1-git-send-email-drafnel@example.com>
2008-05-09  2:19 ` [PATCH 1/5] mktag.c: adjust verify_tag parameters drafnel
2008-05-11 18:39   ` Junio C Hamano
2008-05-12 15:43     ` Brandon Casey
     [not found] ` <1210299589-10448-2-git-send-email-drafnel@example.com>
2008-05-09  2:19   ` [PATCH 2/5] Make mktag a builtin drafnel
2008-05-11 17:28     ` Junio C Hamano
2008-05-11 17:36       ` Junio C Hamano
2008-05-12 15:09       ` Brandon Casey
2008-05-12 17:04         ` Johannes Schindelin
2008-05-12 17:32           ` Brandon Casey
2008-05-12 18:41         ` Junio C Hamano
     [not found]   ` <1210299589-10448-3-git-send-email-drafnel@example.com>
2008-05-09  2:19     ` [PATCH 3/5] mktag.c: rename verify_tag to verify_tag_buffer drafnel
     [not found]     ` <1210299589-10448-4-git-send-email-drafnel@example.com>
2008-05-09  2:19       ` [PATCH 4/5] mktag.c: consolidate tag functions by merging mktag.c into builtin-tag.c drafnel
     [not found]       ` <1210299589-10448-5-git-send-email-drafnel@example.com>
2008-05-09  2:19         ` drafnel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=859967.1210299539642.JavaMail.teamon@b301.teamon.com \
    --to=drafnel@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).