From: David Kastrup <dak@gnu.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Luciano Rocha <luciano@eurotux.com>,
Pieter de Bie <pdebie@ai.rug.nl>,
git@vger.kernel.org
Subject: Re: [PATCH 01/02/RFC] implement a stat cache
Date: Mon, 21 Apr 2008 12:04:37 +0200 [thread overview]
Message-ID: <85d4ojseve.fsf@lola.goethe.zz> (raw)
In-Reply-To: <alpine.LFD.1.10.0804201520370.2779@woody.linux-foundation.org> (Linus Torvalds's message of "Sun, 20 Apr 2008 15:29:02 -0700 (PDT)")
Linus Torvalds <torvalds@linux-foundation.org> writes:
> So I do think your stat cache could be improved, but for the reasons I
> outlined I would much prefer to make it unimportant instead.
Using a cache for a single algorithmic task is probably a mistake: a
cache tries to keep some data around on the assumption that it might get
used. So it tends to either waste lots of memory or keep the wrong
data. And the reloads increase with the size of the processed data.
Using a sorted-traverse-and-merge algorithm instead never needs to
reload data and relinquishes it as soon as it is no longer needed.
A stat cache is fine for an operating system which has no clue about
what access patterns to except next.
But in this case, our application has the whole task outlines in
advance, and it makes sense organizing it in the best manner.
--
David Kastrup, Kriemhildstr. 15, 44793 Bochum
next prev parent reply other threads:[~2008-04-21 10:05 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-19 19:28 Git performance on OS X Pieter de Bie
2008-04-19 21:22 ` Linus Torvalds
2008-04-19 21:29 ` Linus Torvalds
2008-04-19 22:08 ` Pieter de Bie
2008-04-20 16:17 ` David Kastrup
2008-04-19 21:54 ` Linus Torvalds
2008-04-19 22:00 ` Pieter de Bie
2008-04-19 22:39 ` Linus Torvalds
2008-04-20 4:14 ` Junio C Hamano
2008-04-20 11:13 ` [PATCH 01/02/RFC] implement a stat cache Luciano Rocha
2008-04-20 11:15 ` [PATCH 02/02/RFC] make use of the " Luciano Rocha
2008-04-20 11:18 ` [PATCH 01/02/RFC] implement a " Luciano Rocha
2008-04-20 16:03 ` Linus Torvalds
2008-04-20 22:04 ` Luciano Rocha
2008-04-20 22:29 ` Linus Torvalds
2008-04-20 23:07 ` Linus Torvalds
2008-04-21 0:53 ` Dmitry Potapov
2008-04-21 8:41 ` Johan Herland
2008-04-21 1:21 ` Junio C Hamano
2008-04-21 3:15 ` Linus Torvalds
2008-04-21 3:20 ` Linus Torvalds
2008-04-21 18:27 ` Junio C Hamano
2008-04-21 19:09 ` Linus Torvalds
2008-04-21 20:06 ` Junio C Hamano
2008-04-21 10:04 ` David Kastrup [this message]
2008-04-19 22:44 ` Git performance on OS X Jakub Narebski
2008-04-19 22:50 ` Linus Torvalds
2008-04-19 22:54 ` Linus Torvalds
2008-04-19 23:10 ` Pieter de Bie
2008-04-19 23:26 ` Linus Torvalds
2008-04-19 23:35 ` Roman Shaposhnik
2008-04-19 23:57 ` Pieter de Bie
2008-04-20 0:06 ` Linus Torvalds
2008-04-20 0:21 ` Roman Shaposhnik
2008-04-19 23:56 ` Pieter de Bie
2008-04-20 0:31 ` Linus Torvalds
2008-04-20 1:23 ` Dmitry Potapov
2008-04-20 16:22 ` David Kastrup
2008-04-19 23:04 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=85d4ojseve.fsf@lola.goethe.zz \
--to=dak@gnu.org \
--cc=git@vger.kernel.org \
--cc=luciano@eurotux.com \
--cc=pdebie@ai.rug.nl \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).