From: Denton Liu <liu.denton@gmail.com>
To: Git Mailing List <git@vger.kernel.org>,
Paul Mackerras <paulus@ozlabs.org>
Subject: [PATCH v2 2/2] gitk: replace commented tab with space
Date: Thu, 10 Sep 2020 21:36:34 -0700 [thread overview]
Message-ID: <85d669828bf9455ac101f8177a7f46a94d30a114.1599798976.git.liu.denton@gmail.com> (raw)
In-Reply-To: <cover.1599798976.git.liu.denton@gmail.com>
In the previous commit, the tab indents were mechanically replaced with
spaces. However, one tab, in particular, was missed. This tab was not
considered an indentation because it's hidden behind a comment. Manually
replace this tab with spaces too.
The only tabs that remain in this file are in the "Gitk key bindings"
table where they are used for visual alignment in a user-facing table so
leave those alone.
Signed-off-by: Denton Liu <liu.denton@gmail.com>
---
gitk | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gitk b/gitk
index 1dae9861ac..0380cd8976 100755
--- a/gitk
+++ b/gitk
@@ -4451,7 +4451,7 @@ proc addviewmenu {n} {
.bar.view add radiobutton -label $viewname($n) \
-command [list showview $n] -variable selectedview -value $n
#$viewhlmenu add radiobutton -label $viewname($n) \
- # -command [list addvhighlight $n] -variable selectedhlview
+ # -command [list addvhighlight $n] -variable selectedhlview
}
proc showview {n} {
--
2.28.0.618.gf4bc123cb7
prev parent reply other threads:[~2020-09-11 4:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-10 8:27 [PATCH 0/2] gitk: fix mix of tabs and spaces in indentation Denton Liu
2020-09-10 8:27 ` [PATCH 1/2] gitk: replace spaces with tabs Denton Liu
2020-09-10 8:27 ` [PATCH 2/2] gitk: manually fix whitespace errors Denton Liu
2020-09-10 8:36 ` [PATCH 0/2] gitk: fix mix of tabs and spaces in indentation Denton Liu
2020-09-10 9:17 ` Paul Mackerras
2020-09-11 4:36 ` [PATCH v2 " Denton Liu
2020-09-11 4:36 ` [PATCH v2 1/2] gitk: replace tabs with spaces Denton Liu
2020-10-03 9:14 ` Paul Mackerras
2020-09-11 4:36 ` Denton Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=85d669828bf9455ac101f8177a7f46a94d30a114.1599798976.git.liu.denton@gmail.com \
--to=liu.denton@gmail.com \
--cc=git@vger.kernel.org \
--cc=paulus@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).