From: David Kastrup <dak@gnu.org>
To: Alex Riesen <raa.lkml@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>,
martin f krafft <madduck@madduck.net>,
git discussion list <git@vger.kernel.org>,
439992-quiet@bugs.debian.org
Subject: Re: [PATCH] Remove duplicate pathspecs from ls-files command line
Date: Wed, 29 Aug 2007 23:36:20 +0200 [thread overview]
Message-ID: <85tzqic9bf.fsf@lola.goethe.zz> (raw)
In-Reply-To: <20070829211519.GE11824@steel.home> (Alex Riesen's message of "Wed\, 29 Aug 2007 23\:15\:19 +0200")
Alex Riesen <raa.lkml@gmail.com> writes:
> Junio C Hamano, Wed, Aug 29, 2007 22:44:22 +0200:
>>
>> That loop is plain old O(n^2) that penalizes everybody.
>>
>
> Maybe something in pathspec matching code could be reused to notice
> the duplications? It has to go through all of them anyway...
Does anything speak against sorting the pathspecs? That is an O(n log
n) operation, and dup detection is trivial afterwards.
--
David Kastrup, Kriemhildstr. 15, 44793 Bochum
next prev parent reply other threads:[~2007-08-29 21:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-29 8:11 double occurrence of filenames on command lines martin f krafft
2007-08-29 19:44 ` [PATCH] Remove duplicate pathspecs from ls-files command line Alex Riesen
2007-08-29 20:44 ` Junio C Hamano
2007-08-29 21:04 ` martin f krafft
2007-08-29 21:15 ` Alex Riesen
2007-08-29 21:36 ` David Kastrup [this message]
2007-08-30 1:25 ` Junio C Hamano
2007-08-30 5:52 ` David Kastrup
2007-08-29 20:57 ` martin f krafft
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=85tzqic9bf.fsf@lola.goethe.zz \
--to=dak@gnu.org \
--cc=439992-quiet@bugs.debian.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=madduck@madduck.net \
--cc=raa.lkml@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox