git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: merlyn@stonehenge.com (Randal L. Schwartz)
To: Junio C Hamano <junkio@cox.net>
Cc: Theodore Ts'o <tytso@mit.edu>, git@vger.kernel.org
Subject: Re: [PATCH] Rename warn() to warning() to fix symbol conflicts on BSD and Mac OS
Date: Sat, 31 Mar 2007 07:48:35 -0700	[thread overview]
Message-ID: <863b3lfozg.fsf@blue.stonehenge.com> (raw)
In-Reply-To: <7vejn5ygkc.fsf@assigned-by-dhcp.cox.net> (Junio C. Hamano's message of "Sat, 31 Mar 2007 01:15:31 -0700")

>>>>> "Junio" == Junio C Hamano <junkio@cox.net> writes:

Junio> I'd take this for now, but I wonder where we should stop.  If
Junio> somebody exports error() or die(), would we end up renaming them
Junio> to git_error() and git_die()?

I realize you may see it as a slippery slope, but I haven't heard anything
else reported yet, and git has already been ported quite a bit.  But since C
has a flat namespace, this will always be a problem.

Picking a name like warn(3) was probably dumb on bsd's part, but it *is* a
generic call like perror(3).

-- 
Randal L. Schwartz - Stonehenge Consulting Services, Inc. - +1 503 777 0095
<merlyn@stonehenge.com> <URL:http://www.stonehenge.com/merlyn/>
Perl/Unix/security consulting, Technical writing, Comedy, etc. etc.
See PerlTraining.Stonehenge.com for onsite and open-enrollment Perl training!

  parent reply	other threads:[~2007-03-31 14:48 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-03-30 23:07 [PATCH] Rename warn() to warning() to fix symbol conflicts on BSD and Mac OS Theodore Ts'o
2007-03-31  8:15 ` Junio C Hamano
2007-03-31 10:46   ` Johannes Schindelin
2007-03-31 14:48   ` Randal L. Schwartz [this message]
2007-04-01 10:25   ` Alex Riesen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=863b3lfozg.fsf@blue.stonehenge.com \
    --to=merlyn@stonehenge.com \
    --cc=git@vger.kernel.org \
    --cc=junkio@cox.net \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).