git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johannes Schindelin <johannes.schindelin@gmx.de>
To: Johannes Sixt <j6t@kdbg.org>
Cc: Git Mailing List <git@vger.kernel.org>,
	msysGit <msysgit@googlegroups.com>
Subject: Re: [PATCH bc/connect-plink] t5601-clone: remove broken and pointless check for plink.exe
Date: Wed, 12 Aug 2015 13:07:31 +0200	[thread overview]
Message-ID: <866a41f50ef9b4807da72576a4bca717@www.dscho.org> (raw)
In-Reply-To: <55CA6066.5070500@kdbg.org>

Hi Johannes,

On 2015-08-11 22:51, Johannes Sixt wrote:
> Invoking plink requires special treatment, and we have support and even
> test cases for the commands 'plink' and 'tortoiseplink'. We also support
> .exe variants for these two and there is a test for 'plink.exe'.
> 
> On Windows, however, where support for plink.exe would be relevant, the
> test case fails because it is not possible to execute a file with a .exe
> extension that is actually not a binary executable---it is a shell
> script in our test. We have to disable the test case on Windows.

Oh how would I wish you were working on Git for Windows even *just* a bit *with* me. At least I would wish for a more specific description of the development environment, because it sure as hell is not anything anybody can download and install as easily as Git for Windows' SDK.

FWIW Git for Windows has this patch (that I wanted to contribute in due time, what with being busy with all those tickets) to solve the problem mentioned in your patch in a different way:

https://github.com/git-for-windows/git/commit/2fff4b54a0d4e5c5e2e4638c9b0739d3c1ff1e45

Please read this as my vote not to remove the test cases.

Thanks,
Johannes

  parent reply	other threads:[~2015-08-12 11:07 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-11 20:51 [PATCH bc/connect-plink] t5601-clone: remove broken and pointless check for plink.exe Johannes Sixt
2015-08-11 22:50 ` Eric Sunshine
2015-08-11 22:53   ` Junio C Hamano
2015-08-11 22:56   ` [msysGit] " Junio C Hamano
2015-08-11 23:26     ` Eric Sunshine
2015-08-12 11:07 ` Johannes Schindelin [this message]
2015-08-12 11:58   ` [msysGit] " Erik Faye-Lund
2015-08-12 18:31     ` Johannes Sixt
2015-08-13  7:30       ` Johannes Schindelin
2015-08-13 18:07         ` [msysGit] " Johannes Sixt
2015-08-13  8:37     ` Johannes Schindelin
2015-08-13  8:56       ` [msysGit] " Erik Faye-Lund

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=866a41f50ef9b4807da72576a4bca717@www.dscho.org \
    --to=johannes.schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=j6t@kdbg.org \
    --cc=msysgit@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).