From: David Kastrup <dak@gnu.org>
To: git@vger.kernel.org
Subject: Re: [PATCH] diff: don't run pager if user asked for a diff style exit code
Date: Mon, 13 Aug 2007 12:23:16 +0200 [thread overview]
Message-ID: <86d4xrka23.fsf@lola.quinscape.zz> (raw)
In-Reply-To: 13516449-DEDB-41A1-8880-42CB124A6C0A@wincent.com
Wincent Colaiuta <win@wincent.com> writes:
> El 12/8/2007, a las 19:46, René Scharfe escribió:
>
>> Push pager setup down into builtin-diff.c and don't start the pager
>> if --exit-code or --quiet (which implies --exit-code) was specified.
>
> Great stuff, René. The change looks much simpler than I thought it
> would.
Personally, I'd start the pager only when the first diff or stat gets
output, anyway. For a summary message or even a silent exit, a pager
is annoying, regardless of whether --exit-code was specified.
--
David Kastrup
next prev parent reply other threads:[~2007-08-13 10:24 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-11 23:12 --exit-code (and --quiet) broken in git-diff? Wincent Colaiuta
2007-08-12 9:40 ` René Scharfe
2007-08-12 11:24 ` Wincent Colaiuta
2007-08-12 11:31 ` David Kastrup
2007-08-12 13:02 ` Steven Grimm
2007-08-12 13:29 ` David Kastrup
2007-08-12 16:57 ` Wincent Colaiuta
2007-08-12 11:33 ` Steffen Prohaska
2007-08-12 17:46 ` [PATCH] diff: don't run pager if user asked for a diff style exit code René Scharfe
2007-08-13 9:57 ` Wincent Colaiuta
2007-08-13 10:23 ` David Kastrup [this message]
2007-08-13 23:42 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86d4xrka23.fsf@lola.quinscape.zz \
--to=dak@gnu.org \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).