From: Kjetil Barvik <barvik@broadpark.no>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH] Cleanup of unused symcache variable inside diff-lib.c
Date: Sun, 11 Jan 2009 21:09:23 +0100 [thread overview]
Message-ID: <86eiz98v0s.fsf@broadpark.no> (raw)
In-Reply-To: <alpine.DEB.1.00.0901112044230.3586@pacific.mpi-cbg.de>
Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
<snipp>
> My question was more: why do you do additional work and put a git diff
> --raw between the commit message and the diffstat when that information is
> in the patch already?
Ok, I see. I (re)used the 'git format-patch' command from previous
run, and this time it was (without the line-breaks):
git format-patch --stat --patch-with-raw -1 --signoff -M -C
--summary --full-index --subject-prefix="PATCH"
--output-directory ../diff_lib_c_symcache_cleanup_v1/
Regarding the '--summary' I think it is a nice thing to do (so I try
to always use it), and the '--full-index' is such that the git software
have a less chance of producing a collision.
-- kjetil
next prev parent reply other threads:[~2009-01-11 20:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-11 18:36 [PATCH] Cleanup of unused symcache variable inside diff-lib.c Kjetil Barvik
2009-01-11 18:45 ` Johannes Schindelin
2009-01-11 19:32 ` Kjetil Barvik
2009-01-11 19:46 ` Johannes Schindelin
2009-01-11 20:09 ` Kjetil Barvik [this message]
2009-01-11 20:17 ` Johannes Schindelin
2009-01-11 20:50 ` Kjetil Barvik
2009-01-11 22:25 ` Junio C Hamano
2009-01-11 22:23 ` Junio C Hamano
2009-01-12 5:39 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86eiz98v0s.fsf@broadpark.no \
--to=barvik@broadpark.no \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).