From: David Kastrup <dak@gnu.org>
To: git@vger.kernel.org
Subject: Re: [BUG] t7004 (master) busted on Leopard
Date: Thu, 15 Nov 2007 15:48:33 +0100 [thread overview]
Message-ID: <86k5oj36pq.fsf@lola.quinscape.zz> (raw)
In-Reply-To: Pine.LNX.4.64.0711151434060.30886@racer.site
Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> Hi,
>
> On Thu, 15 Nov 2007, Wincent Colaiuta wrote:
>
>> Commit 4d8b1dc850 added a couple of tests to t7004, and my testing reveals
>> that this one has been broken on Leopard since then:
>>
>> * FAIL 83: message in editor has initial comment
>> GIT_EDITOR=cat git tag -a initial-comment > actual || true &&
>> test $(sed -n "/^\(#\|\$\)/p" actual | wc -l) -gt 0
>
> I think this is our good old friend, MacOSX' sed. (Wasn't there a
> question today what's wrong with using sed? I think this issue
> qualifies.)
\| is not portable. $ in groups is not portable.
> I imagine that it is that MacOSX' sed is adding a trailing newline (not
> the regexp like you suggested).
I imagine it is one of the above. Most sed's add trailing newlines.
--
David Kastrup
next prev parent reply other threads:[~2007-11-15 14:50 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-15 13:38 [BUG] t7004 (master) busted on Leopard Wincent Colaiuta
2007-11-15 14:37 ` Johannes Schindelin
2007-11-15 14:48 ` David Kastrup [this message]
2007-11-15 15:12 ` Wincent Colaiuta
2007-11-15 15:16 ` [PATCH] Fix git-tag test breakage caused by broken sed " Wincent Colaiuta
2007-11-15 15:47 ` [PATCH v2] " Wincent Colaiuta
[not found] ` <7v4pfm3h6f.fsf@gitster.siamese.dyndns.org>
2007-11-16 13:45 ` Wincent Colaiuta
2007-11-16 13:48 ` Wincent Colaiuta
2007-11-16 16:59 ` Mike Hommey
2007-11-16 17:25 ` Wincent Colaiuta
2007-11-16 17:26 ` [PATCH] Fix t7004 which fails with retarded sed Mike Hommey
2007-11-16 17:58 ` Benoit Sigoure
2007-11-16 19:15 ` Mike Hommey
2007-11-16 18:02 ` Wincent Colaiuta
2007-11-16 18:26 ` Junio C Hamano
2007-11-16 19:17 ` Mike Hommey
2007-11-16 19:36 ` Junio C Hamano
2007-11-16 20:28 ` [PATCH] Fix and improve t7004 Mike Hommey
2007-11-16 21:04 ` Benoit Sigoure
2007-11-16 21:11 ` Mike Hommey
2007-11-16 21:31 ` Benoit Sigoure
2007-11-16 21:35 ` Mike Hommey
2007-11-16 21:47 ` Benoit Sigoure
2007-11-16 21:42 ` Junio C Hamano
2007-11-16 22:02 ` Mike Hommey
2007-11-17 8:55 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86k5oj36pq.fsf@lola.quinscape.zz \
--to=dak@gnu.org \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).