* [PATCH] gitk doesn't handle filenames with space correctly
@ 2007-04-07 1:22 Frédéric Jolliton
2007-04-12 0:00 ` Bernt Hansen
0 siblings, 1 reply; 2+ messages in thread
From: Frédéric Jolliton @ 2007-04-07 1:22 UTC (permalink / raw)
To: git
Hi,
Here is an attempt to fix gitk such that it can display filenames with
space correctly, in the right column (Patch/Tree). I don't know TCL, so
probably that a better solution exists.
--- gitk.orig 2007-04-07 02:36:05.000000000 +0200
+++ gitk 2007-04-07 03:13:16.000000000 +0200
@@ -4114,8 +4114,7 @@
while {[gets $gtf line] >= 0} {
if {[lindex $line 1] ne "blob"} continue
- set sha1 [lindex $line 2]
- set fname [lindex $line 3]
+ regexp {^[^ ]+ [^ ]+ ([^ ]+)\t(.*)} $line -> sha1 fname
lappend treefilelist($id) $fname
lappend treeidlist($id) $sha1
}
@@ -4324,7 +4323,7 @@
}
return
}
- set file [lindex $line 5]
+ regexp {^[^ ]+ [^ ]+ [^ ]+ [^ ]+ [^ ]+\t(.*)} $line -> file
lappend treediff $file
}
--
Frédéric Jolliton
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] gitk doesn't handle filenames with space correctly
2007-04-07 1:22 [PATCH] gitk doesn't handle filenames with space correctly Frédéric Jolliton
@ 2007-04-12 0:00 ` Bernt Hansen
0 siblings, 0 replies; 2+ messages in thread
From: Bernt Hansen @ 2007-04-12 0:00 UTC (permalink / raw)
To: git
Frédéric Jolliton <gmane@frederic.jolliton.com> writes:
> Here is an attempt to fix gitk such that it can display filenames with
> space correctly, in the right column (Patch/Tree). I don't know TCL, so
> probably that a better solution exists.
Thanks Frédéric!
This patch works great for me.
:)
Bernt
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-04-12 0:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-04-07 1:22 [PATCH] gitk doesn't handle filenames with space correctly Frédéric Jolliton
2007-04-12 0:00 ` Bernt Hansen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).