From: Junio C Hamano <gitster@pobox.com>
To: Eric Sunshine <sunshine@sunshineco.com>
Cc: oneee <kimww0306@gmail.com>,
Kristoffer Haugsbakk <kristofferhaugsbakk@fastmail.com>,
Josh Soref <gitgitgadget@gmail.com>,
git@vger.kernel.org, Patrick Steinhardt <ps@pks.im>
Subject: Re: [PATCH] doc: sparse-checkout: Fix list markers
Date: Fri, 30 May 2025 06:38:03 -0700 [thread overview]
Message-ID: <871ps6b4n8.fsf@gitster.g> (raw)
In-Reply-To: CAPig+cQbchWLMH+pTVfLHwFshaex2vhC8Pk57EC4U-vch00ZDA@mail.gmail.com
Eric Sunshine <sunshine@sunshineco.com> writes:
> You're welcome to submit an additional patch implementing Kristoffer's
> suggestion. Normally, it would make sense to send them both as a
> two-patch series, however, I'm not so sure that that would be a good
> idea in this case. The reason I question it is that the original patch
> is an obvious and uncontroversial fix, however, Kristoffer's
> suggestion -- because it is a subjective change -- may get pushback
> from reviewers.
I had the same thought. If I were working on this topic, I'd send
the original as-is with the suggested name fix, let it graduate, and
then after all the dust settled, do enumeration-style changes as a
new and totally independent patch, which may cover enumerations
other than this single instance.
Thanks.
next prev parent reply other threads:[~2025-05-30 13:38 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-21 12:41 [PATCH] doc: sparse-checkout: Fix list markers oneee via GitGitGadget
2025-05-28 6:56 ` Kristoffer Haugsbakk
2025-05-28 7:20 ` Eric Sunshine
2025-05-28 8:01 ` Kristoffer Haugsbakk
2025-05-30 3:43 ` oneee
2025-05-30 5:00 ` Eric Sunshine
2025-05-30 7:18 ` oneee
2025-05-30 13:38 ` Junio C Hamano [this message]
2025-05-28 7:14 ` Patrick Steinhardt
2025-05-30 7:22 ` [PATCH v2] doc: sparse-checkout: use consistent inline list style oneee via GitGitGadget
2025-05-30 7:41 ` Kristoffer Haugsbakk
-- strict thread matches above, loose matches on Subject: below --
2025-05-28 6:19 [PATCH] doc: sparse-checkout: Fix list markers oneee
2025-05-28 6:36 ` Kristoffer Haugsbakk
2025-05-28 7:14 ` Patrick Steinhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871ps6b4n8.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=kimww0306@gmail.com \
--cc=kristofferhaugsbakk@fastmail.com \
--cc=ps@pks.im \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).