* [PATCH] git.el: find the git-status buffer whatever its name is
@ 2008-02-22 21:45 Rémi Vanicat
2008-02-28 12:58 ` Remi Vanicat
0 siblings, 1 reply; 6+ messages in thread
From: Rémi Vanicat @ 2008-02-22 21:45 UTC (permalink / raw)
To: git; +Cc: julliard
git-status used the buffer name to find git-status buffers, and that
could failed if the buffer had another name, for example when multiple
working directories was tracked.
Signed-off-by: Rémi Vanicat <vanicat@debian.org>
---
contrib/emacs/git.el | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/contrib/emacs/git.el b/contrib/emacs/git.el
index f69b697..14a1601 100644
--- a/contrib/emacs/git.el
+++ b/contrib/emacs/git.el
@@ -1545,7 +1545,7 @@ Commands:
(with-current-buffer buffer
(when (and list-buffers-directory
(string-equal fulldir (expand-file-name list-buffers-directory))
- (string-match "\\*git-status\\*$" (buffer-name buffer)))
+ (eq major-mode 'git-status-mode))
(setq found buffer))))
(setq list (cdr list)))
found))
--
1.5.4.2.191.g7b407
--
Rémi Vanicat
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] git.el: find the git-status buffer whatever its name is
2008-02-22 21:45 [PATCH] git.el: find the git-status buffer whatever its name is Rémi Vanicat
@ 2008-02-28 12:58 ` Remi Vanicat
2008-02-28 14:03 ` Alexandre Julliard
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Remi Vanicat @ 2008-02-28 12:58 UTC (permalink / raw)
To: julliard; +Cc: git, Junio C Hamano
Any comment on this bug fix ? It seem it was forgotten.
I re-include it for convenience:
From 8ab57162a69c178dbc04bc4f94271e36ee9d120a Mon Sep 17 00:00:00 2001
From: Rémi Vanicat <vanicat@debian.org>
Date: Fri, 22 Feb 2008 22:36:23 +0100
Subject: [PATCH] git.el: find the git-status buffer whatever its name is
git-status used the buffer name to find git-status buffers, and that
could failed if the buffer had another name, for example when multiple
working directories was tracked.
---
contrib/emacs/git.el | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/contrib/emacs/git.el b/contrib/emacs/git.el
index f69b697..14a1601 100644
--- a/contrib/emacs/git.el
+++ b/contrib/emacs/git.el
@@ -1545,7 +1545,7 @@ Commands:
(with-current-buffer buffer
(when (and list-buffers-directory
(string-equal fulldir (expand-file-name list-buffers-directory))
- (string-match "\\*git-status\\*$" (buffer-name buffer)))
+ (eq major-mode 'git-status-mode))
(setq found buffer))))
(setq list (cdr list)))
found))
--
1.5.4.2.191.g7b407
--
Rémi Vanicat
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] git.el: find the git-status buffer whatever its name is
2008-02-28 12:58 ` Remi Vanicat
@ 2008-02-28 14:03 ` Alexandre Julliard
2008-02-28 20:14 ` Junio C Hamano
2008-02-29 2:00 ` Xavier Maillard
2 siblings, 0 replies; 6+ messages in thread
From: Alexandre Julliard @ 2008-02-28 14:03 UTC (permalink / raw)
To: Remi Vanicat; +Cc: git, Junio C Hamano
Remi Vanicat <vanicat@debian.org> writes:
> Any comment on this bug fix ? It seem it was forgotten.
> I re-include it for convenience:
Looks good to me.
--
Alexandre Julliard
julliard@winehq.org
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] git.el: find the git-status buffer whatever its name is
2008-02-28 12:58 ` Remi Vanicat
2008-02-28 14:03 ` Alexandre Julliard
@ 2008-02-28 20:14 ` Junio C Hamano
2008-02-29 18:28 ` Rémi Vanicat
2008-02-29 2:00 ` Xavier Maillard
2 siblings, 1 reply; 6+ messages in thread
From: Junio C Hamano @ 2008-02-28 20:14 UTC (permalink / raw)
To: Remi Vanicat; +Cc: julliard, git
Remi Vanicat <vanicat@debian.org> writes:
> Any comment on this bug fix ? It seem it was forgotten.
> I re-include it for convenience:
It is very cumbersome to apply if you "include everything
inside", so please don't do this.
Instead, send as if it is a new patch, adding Acked-by: by Alexandre
after your Signed-off-by: line.
> From 8ab57162a69c178dbc04bc4f94271e36ee9d120a Mon Sep 17 00:00:00 2001
> From: Rémi Vanicat <vanicat@debian.org>
> Date: Fri, 22 Feb 2008 22:36:23 +0100
> Subject: [PATCH] git.el: find the git-status buffer whatever its name is
>
> git-status used the buffer name to find git-status buffers, and that
> could failed if the buffer had another name, for example when multiple
> working directories was tracked.
> ---
> contrib/emacs/git.el | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/contrib/emacs/git.el b/contrib/emacs/git.el
> index f69b697..14a1601 100644
> --- a/contrib/emacs/git.el
> +++ b/contrib/emacs/git.el
> @@ -1545,7 +1545,7 @@ Commands:
> (with-current-buffer buffer
> (when (and list-buffers-directory
> (string-equal fulldir (expand-file-name list-buffers-directory))
> - (string-match "\\*git-status\\*$" (buffer-name buffer)))
> + (eq major-mode 'git-status-mode))
> (setq found buffer))))
> (setq list (cdr list)))
> found))
> --
> 1.5.4.2.191.g7b407
>
>
> --
> Rémi Vanicat
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] git.el: find the git-status buffer whatever its name is
2008-02-28 20:14 ` Junio C Hamano
@ 2008-02-29 18:28 ` Rémi Vanicat
0 siblings, 0 replies; 6+ messages in thread
From: Rémi Vanicat @ 2008-02-29 18:28 UTC (permalink / raw)
To: git; +Cc: julliard, Junio C Hamano
[-- Attachment #1: Type: text/plain, Size: 1038 bytes --]
git-status used the buffer name to find git-status buffers, and that
could failed if the buffer had another name, for example when multiple
working directories was tracked.
Signed-off-by: Rémi Vanicat <vanicat@debian.org>
Acked-by: Alexandre Julliard <julliard@winehq.org>
Tested-by: Xavier Maillard <xma@gnu.org>
---
Resend as requested
contrib/emacs/git.el | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/contrib/emacs/git.el b/contrib/emacs/git.el
index f69b697..14a1601 100644
--- a/contrib/emacs/git.el
+++ b/contrib/emacs/git.el
@@ -1545,7 +1545,7 @@ Commands:
(with-current-buffer buffer
(when (and list-buffers-directory
(string-equal fulldir (expand-file-name list-buffers-directory))
- (string-match "\\*git-status\\*$" (buffer-name buffer)))
+ (eq major-mode 'git-status-mode))
(setq found buffer))))
(setq list (cdr list)))
found))
--
1.5.4.2.191.g7b407
--
Rémi Vanicat
[-- Attachment #2: Type: text/plain, Size: 22 bytes --]
--
Rémi Vanicat
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] git.el: find the git-status buffer whatever its name is
2008-02-28 12:58 ` Remi Vanicat
2008-02-28 14:03 ` Alexandre Julliard
2008-02-28 20:14 ` Junio C Hamano
@ 2008-02-29 2:00 ` Xavier Maillard
2 siblings, 0 replies; 6+ messages in thread
From: Xavier Maillard @ 2008-02-29 2:00 UTC (permalink / raw)
To: Remi Vanicat; +Cc: julliard, git, gitster
Any comment on this bug fix ? It seem it was forgotten.
I re-include it for convenience:
Tested here, it works like a champ.
Xavier
--
http://www.gnu.org
http://www.april.org
http://www.lolica.org
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2008-02-29 18:29 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-02-22 21:45 [PATCH] git.el: find the git-status buffer whatever its name is Rémi Vanicat
2008-02-28 12:58 ` Remi Vanicat
2008-02-28 14:03 ` Alexandre Julliard
2008-02-28 20:14 ` Junio C Hamano
2008-02-29 18:28 ` Rémi Vanicat
2008-02-29 2:00 ` Xavier Maillard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).