From: "David Kågedal" <davidk@lysator.liu.se>
To: git@vger.kernel.org
Cc: Jakub Narebski <jnareb@gmail.com>
Subject: Re: [PATCH 6/7] git-blame.el: Doc fixes and cleanup
Date: Fri, 09 Feb 2007 12:02:59 +0100 [thread overview]
Message-ID: <871wkzpp98.fsf@morpheus.local> (raw)
In-Reply-To: eqhfdv$8uq$1@sea.gmane.org
Jakub Narebski <jnareb@gmail.com> writes:
> [Cc: git@vger.kernel.org]
>
> David K?gedal wrote:
>
>> @@ -123,6 +123,7 @@
>>
>> ;;;###autoload
>> (defun git-blame-mode (&optional arg)
>> + "Minor mode for displaying Git blame"
>> (interactive "P")
>> (if arg
>> (setq git-blame-mode (eq arg 1))
>
> We should probably also change file description in header, and autoload
> instruction in Installation: section of commentary:
Agreed.
> ;;; git-blame.el --- Minor mode for displaying Git blame -*- coding: utf-8 -*-
> ;;
>
> [...]
>
> ;; If you do not want to load this package before it is necessary, you
> ;; can make use of the `autoload' feature, e.g. by adding to your .emacs
> ;; the following lines
> ;;
> ;; (autoload 'git-blame-mode "git-blame"
> ;; "Minor mode for displaying Git blame" t)
>
> (docstring is needed because INTERACTIVE is _fourth_ parameter).
Yes? Of course you need the doc string here, since the file isn't
loaded yet.
--
David Kågedal
prev parent reply other threads:[~2007-02-09 11:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-09 8:21 [PATCH 6/7] git-blame.el: Doc fixes and cleanup David Kågedal
2007-02-09 9:39 ` Jakub Narebski
2007-02-09 11:02 ` David Kågedal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871wkzpp98.fsf@morpheus.local \
--to=davidk@lysator.liu.se \
--cc=git@vger.kernel.org \
--cc=jnareb@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).