From: Adrian Ratiu <adrian.ratiu@collabora.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, Patrick Steinhardt <ps@pks.im>,
Emily Shaffer <emilyshaffer@google.com>,
Jeff King <peff@peff.net>
Subject: Re: [PATCH 1/1] builtin/receive-pack: avoid spinning no-op sideband async threads
Date: Tue, 03 Mar 2026 14:47:50 +0200 [thread overview]
Message-ID: <87342hoz9l.fsf@collabora.com> (raw)
In-Reply-To: <xmqq4imxzz90.fsf@gitster.g>
On Mon, 02 Mar 2026, Junio C Hamano <gitster@pobox.com> wrote:
>> @@ -1674,6 +1680,9 @@ static void run_update_post_hook(struct command *commands)
>> int sideband_async_started = 0;
>> int saved_stderr = -1;
>>
>> + if (!hook_exists(the_repository, "post-update"))
>> + return;
>> +
>> for (cmd = commands; cmd; cmd = cmd->next) {
>> if (cmd->error_string || cmd->did_not_exist)
>> continue;
>
> Ditto for "post-update".
>
> Will queue with the following change squashed in.
Thank you Junio, much appreciated!
next prev parent reply other threads:[~2026-03-03 12:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-02 19:17 [PATCH 0/1] Fix update hook perf regression in next Adrian Ratiu
2026-03-02 19:17 ` [PATCH 1/1] builtin/receive-pack: avoid spinning no-op sideband async threads Adrian Ratiu
2026-03-02 21:40 ` Junio C Hamano
2026-03-03 12:47 ` Adrian Ratiu [this message]
2026-03-03 6:11 ` Patrick Steinhardt
2026-03-03 12:45 ` Adrian Ratiu
2026-03-03 13:28 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87342hoz9l.fsf@collabora.com \
--to=adrian.ratiu@collabora.com \
--cc=emilyshaffer@google.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox