From: Thomas Rast <trast@student.ethz.ch>
To: Junio C Hamano <gitster@pobox.com>
Cc: Jon Seymour <jon.seymour@gmail.com>, <git@vger.kernel.org>,
<normalperson@yhbt.net>
Subject: Re: [PATCH v2] git-svn: clarify the referent of dcommit's optional argument
Date: Fri, 18 May 2012 10:27:46 +0200 [thread overview]
Message-ID: <87396xj3lp.fsf@thomas.inf.ethz.ch> (raw)
In-Reply-To: 7vliktfoza.fsf@alter.siamese.dyndns.org
Junio C Hamano <gitster@pobox.com> writes:
> Jon Seymour <jon.seymour@gmail.com> writes:
>
>> On Tue, May 15, 2012 at 2:16 AM, Junio C Hamano <gitster@pobox.com> wrote:
>>>
>>> The only reason why the original is not ordered that way, as far as I can
>>> tell, is because "It is recommended that" was part of an existing paragraph
>>> when dd31da2 (git-svn: allow dcommit to take an alternate head, 2006-12-12)
>>> added "An optional ...", so it was tucked after existing paragraph without
>>> reading the resulting whole to see if "at the very end" was the best place.
>>
>> Re-reading this, I don't think the advice:
>>
>> "It is recommended that you run 'git svn' fetch and rebase (not
>> pull or merge) your commits against the latest changes in the =C2=A0SVN
>> repository."
>>
>> really belongs in the description of dcommit at all.
>
> I tend to agree. Opinions from git-svn experts?
I agree that this is not dcommit-specific advice. Perhaps there should
be a longer section that explains in detail what is rebased how and thus
what the limitations of dcommit are.
--
Thomas Rast
trast@{inf,student}.ethz.ch
prev parent reply other threads:[~2012-05-18 8:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-14 6:53 [PATCH v2] git-svn: clarify the referent of dcommit's optional argument Jon Seymour
2012-05-14 12:48 ` Jon Seymour
2012-05-14 16:16 ` Junio C Hamano
2012-05-15 11:15 ` Jon Seymour
2012-05-15 15:22 ` Junio C Hamano
2012-05-16 0:59 ` Eric Wong
2012-05-18 8:27 ` Thomas Rast [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87396xj3lp.fsf@thomas.inf.ethz.ch \
--to=trast@student.ethz.ch \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jon.seymour@gmail.com \
--cc=normalperson@yhbt.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).