From: Thomas Rast <trast@student.ethz.ch>
To: Shawn Pearce <spearce@spearce.org>
Cc: Junio C Hamano <gitster@pobox.com>, <git@vger.kernel.org>
Subject: Re: [PATCH] remote-curl: Fix push status report when all branches fail
Date: Fri, 20 Jan 2012 17:17:54 +0100 [thread overview]
Message-ID: <8739bacpql.fsf@thomas.inf.ethz.ch> (raw)
In-Reply-To: <CAJo=hJtCb=WFfuSKWvPk+S4sRQmSGemG_Ugqj+k1TZCOJj9vLQ@mail.gmail.com> (Shawn Pearce's message of "Fri, 20 Jan 2012 07:15:02 -0800")
Shawn Pearce <spearce@spearce.org> writes:
> On Thu, Jan 19, 2012 at 22:00, Junio C Hamano <gitster@pobox.com> wrote:
>> "Shawn O. Pearce" <spearce@spearce.org> writes:
>>> +cat >exp <<EOF
>>> +remote: error: hook declined to update refs/heads/dev2
>>
>> Curious. Where do we get these eight trailing whitespaces?
>
> I think this is padding being added to the end of the line by
> recv_sideband(). I noticed the trailing whitespace in the diff, but
> the test passed with it present, so I had to leave it in.
ISTR we had a policy to guard such whitespace at EOL? Compare
e.g. c1376c12b7.
--
Thomas Rast
trast@{inf,student}.ethz.ch
next prev parent reply other threads:[~2012-01-20 16:18 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-19 22:24 [PATCH] remote-curl: Fix push status report when all branches fail Shawn O. Pearce
2012-01-19 22:57 ` Junio C Hamano
2012-01-20 3:12 ` Shawn O. Pearce
2012-01-20 5:49 ` Junio C Hamano
2012-01-20 6:00 ` Junio C Hamano
2012-01-20 15:15 ` Shawn Pearce
2012-01-20 16:17 ` Thomas Rast [this message]
2012-01-20 17:03 ` Shawn O. Pearce
2012-01-20 18:18 ` Junio C Hamano
2012-02-22 10:13 ` Jeff King
2012-02-22 15:22 ` Shawn Pearce
2012-02-22 20:40 ` Jeff King
2012-02-23 10:04 ` Jeff King
2012-02-23 19:11 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8739bacpql.fsf@thomas.inf.ethz.ch \
--to=trast@student.ethz.ch \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).