Test 17 of `t9119-git-svn-info.sh' fails with svn 1.6.9

Test 17 of `t9119-git-svn-info.sh' fails with svn 1.6.9

[Frank Terbeck]

Hello,

Running the test suite currently breaks for me at this point:

[snip]
*   ok 16: info --url added-file
* FAIL 17: info added-directory

                mkdir gitwc/added-directory svnwc/added-directory &&
                ptouch gitwc/added-directory svnwc/added-directory &&
                touch gitwc/added-directory/.placeholder &&
                cd svnwc &&
                        svn_cmd add added-directory > /dev/null &&
                cd .. &&
                cd gitwc &&
                        git add added-directory &&
                cd .. &&
                (cd svnwc; svn info added-directory)            >
                expected.info-added-directory &&
                (cd gitwc; git svn info
                added-directory)                >
                actual.info-added-directory &&
                test_cmp expected.info-added-directory
                actual.info-added-directory

*   ok 18: info --url added-directory
[...]
* failed 1 among 38 test(s)
make[2]: *** [t9119-git-svn-info.sh] Error 1
[snap]

I briefly searched the list archives via gmane but didn't find this
reported yet. I've got no idea what's going on in that test, as I'm no
expert in subversion matters at all. So I can't be of more help than
saying "well, it breaks for me.". :)

Anyway, my svn version is "svn, version 1.6.9 (r901367)". The test suite
I ran is from yesterdays git master branch. If it matters, this is a
Linux box running a debian 2.6.26-2-686 kernel; the file system in
question is `ext3' being mounted `noatime'.

Regards, Frank

PS: I hope I Cced the right group of people.

-- 
In protocol design, perfection has been reached not when there is
nothing left to add, but when there is nothing left to take away.
                                                  -- RFC 1925

Re: Test 17 of `t9119-git-svn-info.sh' fails with svn 1.6.9

[Michael J Gruber]

Frank Terbeck venit, vidit, dixit 01.07.2010 10:54:
> Hello,
> 
> Running the test suite currently breaks for me at this point:
> 
> [snip]
> *   ok 16: info --url added-file
> * FAIL 17: info added-directory
> 
>                 mkdir gitwc/added-directory svnwc/added-directory &&
>                 ptouch gitwc/added-directory svnwc/added-directory &&
>                 touch gitwc/added-directory/.placeholder &&
>                 cd svnwc &&
>                         svn_cmd add added-directory > /dev/null &&
>                 cd .. &&
>                 cd gitwc &&
>                         git add added-directory &&
>                 cd .. &&
>                 (cd svnwc; svn info added-directory)            >
>                 expected.info-added-directory &&
>                 (cd gitwc; git svn info
>                 added-directory)                >
>                 actual.info-added-directory &&
>                 test_cmp expected.info-added-directory
>                 actual.info-added-directory
> 
> *   ok 18: info --url added-directory
> [...]
> * failed 1 among 38 test(s)
> make[2]: *** [t9119-git-svn-info.sh] Error 1
> [snap]
> 
> I briefly searched the list archives via gmane but didn't find this
> reported yet. I've got no idea what's going on in that test, as I'm no
> expert in subversion matters at all. So I can't be of more help than
> saying "well, it breaks for me.". :)
> 
> Anyway, my svn version is "svn, version 1.6.9 (r901367)". The test suite
> I ran is from yesterdays git master branch. If it matters, this is a
> Linux box running a debian 2.6.26-2-686 kernel; the file system in
> question is `ext3' being mounted `noatime'.

It works for me with the exact same svn version on Fedora 13.

Please run the test like that:
cd t
./t9119-git-svn-info.sh -i

This stop immediately after the failed test. Then, please tell us the
contents of the actual.. and expected... files in the trash... subdir.


Michael

> 
> Regards, Frank
> 
> PS: I hope I Cced the right group of people.

Eric's the svn guy, the rest is just other helpful people ;)

Re: Test 17 of `t9119-git-svn-info.sh' fails with svn 1.6.9

[Frank Terbeck]

Michael J Gruber wrote:
> Frank Terbeck venit, vidit, dixit 01.07.2010 10:54:
>> [snip]
>> *   ok 16: info --url added-file
>> * FAIL 17: info added-directory
[...]
>> *   ok 18: info --url added-directory
>> [...]
>> * failed 1 among 38 test(s)
>> make[2]: *** [t9119-git-svn-info.sh] Error 1
>> [snap]
[...]
>> Anyway, my svn version is "svn, version 1.6.9 (r901367)". The test suite
>> I ran is from yesterdays git master branch. If it matters, this is a
>> Linux box running a debian 2.6.26-2-686 kernel; the file system in
>> question is `ext3' being mounted `noatime'.
>
> It works for me with the exact same svn version on Fedora 13.
>
> Please run the test like that:
> cd t
> ./t9119-git-svn-info.sh -i
>
> This stop immediately after the failed test. Then, please tell us the
> contents of the actual.. and expected... files in the trash... subdir.

Okay.

expected.info-added-directory:
[snip]
Path: added-directory
URL: file:///usr/src/sys/git/t/trash%20directory.t9119-git-svn-info/svnrepo/added-directory
Repository Root: file:///usr/src/sys/git/t/trash%20directory.t9119-git-svn-info/svnrepo
Repository UUID: 638d0b70-c7df-46bd-9c56-aff8052b4ab8
Revision: 0
Node Kind: directory
Schedule: add
[snap]

actual.info-added-directory:
[snip]
Path: added-directory
URL: file:///usr/src/sys/git/t/trash%20directory.t9119-git-svn-info/svnrepo/added-directory
Repository Root: file:///usr/src/sys/git/t/trash%20directory.t9119-git-svn-info/svnrepo
Revision: 0
Node Kind: directory
Schedule: add
[snap]

And a unified diff of the two:
[snip]
--- trash directory.t9119-git-svn-info/actual.info-added-directory 2010-07-01 11:22:16.000000000 +0200
+++ trash directory.t9119-git-svn-info/expected.info-added-directory 2010-07-01 11:22:16.000000000 +0200
@@ -1,6 +1,7 @@
 Path: added-directory
 URL: file:///usr/src/sys/git/t/trash%20directory.t9119-git-svn-info/svnrepo/added-directory
 Repository Root: file:///usr/src/sys/git/t/trash%20directory.t9119-git-svn-info/svnrepo
+Repository UUID: 638d0b70-c7df-46bd-9c56-aff8052b4ab8
 Revision: 0
 Node Kind: directory
 Schedule: add
[snap]

Regards, Frank

Re: Test 17 of `t9119-git-svn-info.sh' fails with svn 1.6.9

[Michael J Gruber]

Frank Terbeck venit, vidit, dixit 01.07.2010 11:28:
> Michael J Gruber wrote:
>> Frank Terbeck venit, vidit, dixit 01.07.2010 10:54:
>>> [snip]
>>> *   ok 16: info --url added-file
>>> * FAIL 17: info added-directory
> [...]
>>> *   ok 18: info --url added-directory
>>> [...]
>>> * failed 1 among 38 test(s)
>>> make[2]: *** [t9119-git-svn-info.sh] Error 1
>>> [snap]
> [...]
>>> Anyway, my svn version is "svn, version 1.6.9 (r901367)". The test suite
>>> I ran is from yesterdays git master branch. If it matters, this is a
>>> Linux box running a debian 2.6.26-2-686 kernel; the file system in
>>> question is `ext3' being mounted `noatime'.
>>
>> It works for me with the exact same svn version on Fedora 13.
>>
>> Please run the test like that:
>> cd t
>> ./t9119-git-svn-info.sh -i
>>
>> This stop immediately after the failed test. Then, please tell us the
>> contents of the actual.. and expected... files in the trash... subdir.
> 
> Okay.
> 
> expected.info-added-directory:
> [snip]
> Path: added-directory
> URL: file:///usr/src/sys/git/t/trash%20directory.t9119-git-svn-info/svnrepo/added-directory
> Repository Root: file:///usr/src/sys/git/t/trash%20directory.t9119-git-svn-info/svnrepo
> Repository UUID: 638d0b70-c7df-46bd-9c56-aff8052b4ab8
> Revision: 0
> Node Kind: directory
> Schedule: add
> [snap]
> 
> actual.info-added-directory:
> [snip]
> Path: added-directory
> URL: file:///usr/src/sys/git/t/trash%20directory.t9119-git-svn-info/svnrepo/added-directory
> Repository Root: file:///usr/src/sys/git/t/trash%20directory.t9119-git-svn-info/svnrepo
> Revision: 0
> Node Kind: directory
> Schedule: add
> [snap]
> 
> And a unified diff of the two:
> [snip]
> --- trash directory.t9119-git-svn-info/actual.info-added-directory 2010-07-01 11:22:16.000000000 +0200
> +++ trash directory.t9119-git-svn-info/expected.info-added-directory 2010-07-01 11:22:16.000000000 +0200
> @@ -1,6 +1,7 @@
>  Path: added-directory
>  URL: file:///usr/src/sys/git/t/trash%20directory.t9119-git-svn-info/svnrepo/added-directory
>  Repository Root: file:///usr/src/sys/git/t/trash%20directory.t9119-git-svn-info/svnrepo
> +Repository UUID: 638d0b70-c7df-46bd-9c56-aff8052b4ab8

"Nachtigall, ick hör Dir trapsen." [I really don't know how to translate
this...]

Anyway, this is something I had fixed previously before realizing it
doesn't need a fix and something else is wrong:

It indicates that Git's svn-bindings (git-svn) use a different svn
version than the actual "svn". (There used to be a bug where Git was
wrong about the version of the bindings but that is fixed.)

Do the following agree for you:

git svn --version
svn --version

Do you have any private copies of svn/svn bindings in your path or perl
path?

>  Revision: 0
>  Node Kind: directory
>  Schedule: add
> [snap]
> 
> Regards, Frank

Michael

Re: Test 17 of `t9119-git-svn-info.sh' fails with svn 1.6.9

[Frank Terbeck]

Michael J Gruber wrote:
[...]
>> And a unified diff of the two:
>> [snip]
>> --- trash directory.t9119-git-svn-info/actual.info-added-directory 2010-07-01 11:22:16.000000000 +0200
>> +++ trash directory.t9119-git-svn-info/expected.info-added-directory 2010-07-01 11:22:16.000000000 +0200
>> @@ -1,6 +1,7 @@
>>  Path: added-directory
>>  URL: file:///usr/src/sys/git/t/trash%20directory.t9119-git-svn-info/svnrepo/added-directory
>>  Repository Root: file:///usr/src/sys/git/t/trash%20directory.t9119-git-svn-info/svnrepo
>> +Repository UUID: 638d0b70-c7df-46bd-9c56-aff8052b4ab8
>
> "Nachtigall, ick hör Dir trapsen." [I really don't know how to translate
> this...]

No need. :)

> Anyway, this is something I had fixed previously before realizing it
> doesn't need a fix and something else is wrong:
>
> It indicates that Git's svn-bindings (git-svn) use a different svn
> version than the actual "svn". (There used to be a bug where Git was
> wrong about the version of the bindings but that is fixed.)
>
> Do the following agree for you:
>
> git svn --version
> svn --version
>
> Do you have any private copies of svn/svn bindings in your path or perl
> path?

Okay, it wasn't really a private copy, but you're otherwise
spot-on. Here's what was wrong:

I didn't realise, `git-svn' was using Perl's subversion bindings. This
happens on my laptop which runs debian stable (lenny). I was upgrading
my subversion package to the one provided by backports.org (a service
that provides backports of newer versions of certain software packages
to debian stable). While that worked nicely, the subversion bindings for
Perl are provided by a package called `libsvn-perl' which was kept at
the version in stable, which is 1.5.1. Backports.org also provides an
upgrade for that package. Now both "svn --version" and "git svn
--version" report the same subversion version and the test passes again.


Maybe it would be good if git-svn or maybe just the test suite checked
whether subversion's and the Perl binding's version matched?

Regards, Frank

-- 
In protocol design, perfection has been reached not when there is
nothing left to add, but when there is nothing left to take away.
                                                  -- RFC 1925

Re: Test 17 of `t9119-git-svn-info.sh' fails with svn 1.6.9

[Michael J Gruber]

Frank Terbeck venit, vidit, dixit 01.07.2010 12:19:
> Michael J Gruber wrote:
> [...]
>>> And a unified diff of the two:
>>> [snip]
>>> --- trash directory.t9119-git-svn-info/actual.info-added-directory 2010-07-01 11:22:16.000000000 +0200
>>> +++ trash directory.t9119-git-svn-info/expected.info-added-directory 2010-07-01 11:22:16.000000000 +0200
>>> @@ -1,6 +1,7 @@
>>>  Path: added-directory
>>>  URL: file:///usr/src/sys/git/t/trash%20directory.t9119-git-svn-info/svnrepo/added-directory
>>>  Repository Root: file:///usr/src/sys/git/t/trash%20directory.t9119-git-svn-info/svnrepo
>>> +Repository UUID: 638d0b70-c7df-46bd-9c56-aff8052b4ab8
>>
>> "Nachtigall, ick hör Dir trapsen." [I really don't know how to translate
>> this...]
> 
> No need. :)
> 
>> Anyway, this is something I had fixed previously before realizing it
>> doesn't need a fix and something else is wrong:
>>
>> It indicates that Git's svn-bindings (git-svn) use a different svn
>> version than the actual "svn". (There used to be a bug where Git was
>> wrong about the version of the bindings but that is fixed.)
>>
>> Do the following agree for you:
>>
>> git svn --version
>> svn --version
>>
>> Do you have any private copies of svn/svn bindings in your path or perl
>> path?
> 
> Okay, it wasn't really a private copy, but you're otherwise
> spot-on. Here's what was wrong:

Turns out you cc'ed the right persons :)

> 
> I didn't realise, `git-svn' was using Perl's subversion bindings. This
> happens on my laptop which runs debian stable (lenny). I was upgrading
> my subversion package to the one provided by backports.org (a service
> that provides backports of newer versions of certain software packages
> to debian stable). While that worked nicely, the subversion bindings for
> Perl are provided by a package called `libsvn-perl' which was kept at
> the version in stable, which is 1.5.1. Backports.org also provides an
> upgrade for that package. Now both "svn --version" and "git svn
> --version" report the same subversion version and the test passes again.
> 
> 
> Maybe it would be good if git-svn or maybe just the test suite checked
> whether subversion's and the Perl binding's version matched?

Then you would not be able to use git-svn with your setup!

Having svn and its bindings at different versions is perfectly fine for
git-svn: it uses and cares about the bindings only (and adjusts
according to the binding's version).

It's only the test suite which cares, because it tries to make sure that
"svn" and "git-svn" behave as similar as possible.

We should probably check in the test suite before triggering false
alarms, I'll look into that.

Cheers,
Michael

Re: Test 17 of `t9119-git-svn-info.sh' fails with svn 1.6.9

[Frank Terbeck]

Michael J Gruber wrote:
> Frank Terbeck venit, vidit, dixit 01.07.2010 12:19:
>> Michael J Gruber wrote:
[...]
>>> Do the following agree for you:
>>>
>>> git svn --version
>>> svn --version
>>>
>>> Do you have any private copies of svn/svn bindings in your path or perl
>>> path?
>> 
>> Okay, it wasn't really a private copy, but you're otherwise
>> spot-on. Here's what was wrong:
>
> Turns out you cc'ed the right persons :)

Heh, seems so. :)

>> I didn't realise, `git-svn' was using Perl's subversion bindings. This
>> happens on my laptop which runs debian stable (lenny). I was upgrading
>> my subversion package to the one provided by backports.org (a service
>> that provides backports of newer versions of certain software packages
>> to debian stable). While that worked nicely, the subversion bindings for
>> Perl are provided by a package called `libsvn-perl' which was kept at
>> the version in stable, which is 1.5.1. Backports.org also provides an
>> upgrade for that package. Now both "svn --version" and "git svn
>> --version" report the same subversion version and the test passes again.
>> 
>> 
>> Maybe it would be good if git-svn or maybe just the test suite checked
>> whether subversion's and the Perl binding's version matched?
>
> Then you would not be able to use git-svn with your setup!

Well, now it would. :)
But I get your point.

> Having svn and its bindings at different versions is perfectly fine for
> git-svn: it uses and cares about the bindings only (and adjusts
> according to the binding's version).

Okay.

> It's only the test suite which cares, because it tries to make sure that
> "svn" and "git-svn" behave as similar as possible.
>
> We should probably check in the test suite before triggering false
> alarms, I'll look into that.

Cool thanks.

And thank you for the quick response and solution.

Regards, Frank