git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Florian Weimer <fw@deneb.enyo.de>
To: git@vger.kernel.org
Subject: Re: Shell script cleanups/style changes?
Date: Sat, 04 Aug 2007 09:10:00 +0200	[thread overview]
Message-ID: <873ayzojw7.fsf@mid.deneb.enyo.de> (raw)
In-Reply-To: <20070802214103.GT29424@schiele.dyndns.org> (Robert Schiele's message of "Thu, 2 Aug 2007 23:41:03 +0200")

* Robert Schiele:

>> Sure.  What about the git-rebase line using $(($end - $msgnum)) ?
>
> Bad on Solaris:
>
> $ uname -a
> SunOS solaris10-x64 5.10 Generic i86pc i386 i86pc
> $ end=1
> $ msgnum=5
> $ echo $(($end - $msgnum))
> syntax error: `(' unexpected
> $ 

Is this with /usr/xpg4/bin/sh or /bin/sh?  The latter is not POSIX and
should not be used by GIT, IMHO, otherwise there will be endless
issues in less-well-tested code paths.  Is rewriting the shebang lines
to use the POSIX shell an option for GIT?

  parent reply	other threads:[~2007-08-04  7:10 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-02 10:44 Shell script cleanups/style changes? David Kastrup
2007-08-02 14:00 ` Robert Schiele
2007-08-02 14:20   ` David Kastrup
2007-08-02 16:19     ` Robert Schiele
2007-08-02 17:05       ` Johannes Schindelin
2007-08-02 17:22         ` Robert Schiele
2007-08-03 19:29     ` Uwe Kleine-König
2007-08-02 14:48 ` Bradford Smith
2007-08-02 18:13   ` Sam Ravnborg
2007-08-02 20:37 ` Junio C Hamano
2007-08-02 20:56   ` Nguyen Thai Ngoc Duy
2007-08-02 21:02     ` David Kastrup
2007-08-02 21:12     ` Junio C Hamano
2007-08-02 20:57   ` David Kastrup
2007-08-02 21:21     ` Junio C Hamano
2007-08-02 21:29       ` Junio C Hamano
2007-08-02 22:02         ` David Kastrup
2007-08-02 21:41       ` Robert Schiele
2007-08-02 22:14         ` David Kastrup
2007-08-02 23:05           ` Junio C Hamano
2007-08-02 23:17             ` David Kastrup
2007-08-03  0:12               ` Junio C Hamano
2007-08-03  0:24                 ` David Kastrup
2007-08-03  0:48                   ` Junio C Hamano
2007-08-03  6:06                     ` David Kastrup
2007-08-03  7:41                       ` Junio C Hamano
2007-08-03  8:41                         ` David Kastrup
2007-08-03  6:13                     ` David Kastrup
2007-08-03  2:28                   ` Robert Schiele
2007-08-03  6:08                     ` David Kastrup
2007-08-02 23:21             ` Robert Schiele
2007-08-02 23:32               ` David Kastrup
2007-08-02 23:45                 ` Robert Schiele
2007-08-02 23:52                   ` David Kastrup
2007-08-03  0:01                     ` Robert Schiele
2007-08-03  0:11                       ` David Kastrup
2007-08-03  7:11                         ` Junio C Hamano
2007-08-02 23:27           ` Robert Schiele
2007-08-04  7:10         ` Florian Weimer [this message]
2007-08-04 20:32           ` Robert Schiele
2007-08-04 20:39             ` Junio C Hamano
2007-08-02 21:42       ` David Kastrup

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=873ayzojw7.fsf@mid.deneb.enyo.de \
    --to=fw@deneb.enyo.de \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).