From: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Christian Couder <christian.couder@gmail.com>,
git@vger.kernel.org, Michael Haggerty <mhagger@alum.mit.edu>,
Nguyen Thai Ngoc Duy <pclouds@gmail.com>
Subject: Re: [PATCH 1/3] read-cache: use shared perms when writing shared index
Date: Tue, 13 Nov 2018 16:22:38 +0100 [thread overview]
Message-ID: <874lcl2e9t.fsf@evledraar.gmail.com> (raw)
In-Reply-To: <xmqq8tkjkdgl.fsf@gitster.mtv.corp.google.com>
On Thu, 22 Jun 2017 12:51:54 -0700 Junio wrote:
> > Let's fix that by using create_tempfile() instead of mks_tempfile()
> > to create the shared index file.
> >
> > ...
> > - fd = mks_tempfile(&temporary_sharedindex, git_path("sharedindex_XXXXXX"));
> > + fd = create_tempfile(&temporary_sharedindex, git_path("sharedindex_XXXXXX"));
>
> So we used to create a temporary file that made sure its name is
> unique but now we create sharedindex_XXXXXX with 6 X's literally
> at the end?
I'm looking at some of this again. Yeah that was a bug in Christian's
code, but interestingly if you just create literal sharedindex_XXXXXX
files (don't replace the X's) the whole test suite passes under
GIT_TEST_SPLIT_INDEX=true
That seems like a major blindspot, i.e. we don't seem to have tests that
stress test the case of >1 split index.
next prev parent reply other threads:[~2018-11-13 15:22 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-22 19:01 [PATCH 1/3] read-cache: use shared perms when writing shared index Christian Couder
2017-06-22 19:01 ` [PATCH 2/3] t1301: move movebits() to test-lib-functions.sh Christian Couder
2017-06-22 19:52 ` Junio C Hamano
2017-06-22 23:09 ` Ramsay Jones
2017-06-23 5:31 ` Junio C Hamano
2017-06-23 15:12 ` Christian Couder
2017-06-22 19:01 ` [PATCH 3/3] t1700: make sure split-index respects core.sharedrepository Christian Couder
2017-06-22 19:53 ` Junio C Hamano
2017-06-22 20:19 ` Christian Couder
2017-06-22 20:25 ` Junio C Hamano
2017-06-22 21:07 ` Christian Couder
2017-06-22 19:51 ` [PATCH 1/3] read-cache: use shared perms when writing shared index Junio C Hamano
2017-06-23 15:14 ` Christian Couder
2018-11-13 15:22 ` Ævar Arnfjörð Bjarmason [this message]
2018-11-13 15:32 ` [RFC/PATCH] read-cache: write all indexes with the same permissions Ævar Arnfjörð Bjarmason
2018-11-13 16:55 ` Duy Nguyen
2018-11-13 17:34 ` Ævar Arnfjörð Bjarmason
2018-11-16 17:41 ` Christian Couder
2018-11-16 19:07 ` SZEDER Gábor
2018-11-16 19:19 ` Duy Nguyen
2018-11-17 6:52 ` Christian Couder
2018-11-17 12:38 ` SZEDER Gábor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874lcl2e9t.fsf@evledraar.gmail.com \
--to=avarab@gmail.com \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=mhagger@alum.mit.edu \
--cc=pclouds@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).