git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andreas Schwab <schwab@linux-m68k.org>
To: Steffen Prohaska <prohaska@zib.de>
Cc: John Keeping <john@keeping.me.uk>,
	Junio C Hamano <gitster@pobox.com>,
	Git Mailing List <git@vger.kernel.org>, Jeff King <peff@peff.net>,
	Scott Chacon <schacon@gmail.com>
Subject: Re: [PATCH v2 2/2] convert: Stream from fd to required clean filter instead of mmap
Date: Sat, 16 Aug 2014 19:00:24 +0200	[thread overview]
Message-ID: <874mxc9xp3.fsf@igel.home> (raw)
In-Reply-To: <FA3F1197-25C5-42E4-9418-1C821D430819@zib.de> (Steffen Prohaska's message of "Sat, 16 Aug 2014 18:26:08 +0200")

Steffen Prohaska <prohaska@zib.de> writes:

> The test should confirm that the the file that is added is not mmapped to
> memory.

RSS doesn't tell you that.  You can mmap a big file without RSS getting
bigger.

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

  reply	other threads:[~2014-08-16 17:00 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-06  5:32 [PATCH v2 0/2] Stream fd to clean filter Steffen Prohaska
2014-08-06  5:32 ` [PATCH v2 1/2] convert: Refactor would_convert_to_git() to single arg 'path' Steffen Prohaska
2014-08-06  5:32 ` [PATCH v2 2/2] convert: Stream from fd to required clean filter instead of mmap Steffen Prohaska
2014-08-16 10:27   ` John Keeping
2014-08-16 16:26     ` Steffen Prohaska
2014-08-16 17:00       ` Andreas Schwab [this message]
2014-08-17 10:08         ` Steffen Prohaska
2014-08-17 11:03           ` Andreas Schwab
2014-08-17  7:27       ` Jeff King
2014-08-17 10:25         ` Steffen Prohaska
2014-08-17 11:33           ` Duy Nguyen
2014-08-19  7:53             ` Jeff King
2014-08-19  8:26               ` Steffen Prohaska

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874mxc9xp3.fsf@igel.home \
    --to=schwab@linux-m68k.org \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=john@keeping.me.uk \
    --cc=peff@peff.net \
    --cc=prohaska@zib.de \
    --cc=schacon@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).