[PATCH] post-update.sample referenced obsolete binary "git-update-server-info"

[PATCH] post-update.sample referenced obsolete binary "git-update-server-info"

[Peter Simons]

	Modified 
diff --git a/templates/hooks--post-update.sample b/templates/hooks--post-update.sample
index 5323b56..ec17ec1 100755
--- a/templates/hooks--post-update.sample
+++ b/templates/hooks--post-update.sample
@@ -5,4 +5,4 @@
 #
 # To enable this hook, rename this file to "post-update".
 
-exec git-update-server-info
+exec git update-server-info

Re: [PATCH] post-update.sample referenced obsolete binary "git-update-server-info"

[Michael J Gruber]

Peter Simons venit, vidit, dixit 17.07.2009 17:36:
> 
> 	Modified 
> diff --git a/templates/hooks--post-update.sample b/templates/hooks--post-update.sample
> index 5323b56..ec17ec1 100755
> --- a/templates/hooks--post-update.sample
> +++ b/templates/hooks--post-update.sample
> @@ -5,4 +5,4 @@
>  #
>  # To enable this hook, rename this file to "post-update".
>  
> -exec git-update-server-info
> +exec git update-server-info
> 

Have you actually tried? t/t5540-http-push.sh should fail if this really
needed a fix (libexec is in $PATH for hooks).

Michael

Re: [PATCH] post-update.sample referenced obsolete binary "git-update-server-info"

[Peter Simons]

Hi Michael,

 >> -exec git-update-server-info
 >> +exec git update-server-info
 >>
 >
 > t/t5540-http-push.sh should fail if this really needed a fix (libexec
 > is in $PATH for hooks).

you are right, the call to git-update-server-info does succeed, so there
is no need to make that change.

Personally, I find it unfortunate, though, that those scripts rely on
commands that won't exist when a normal user runs them.

Just my 2 cents,
Peter

Re: [PATCH] post-update.sample referenced obsolete binary "git-update-server-info"

[Michael J Gruber]

Peter Simons venit, vidit, dixit 20.07.2009 16:46:
> Hi Michael,
> 
>  >> -exec git-update-server-info
>  >> +exec git update-server-info
>  >>
>  >
>  > t/t5540-http-push.sh should fail if this really needed a fix (libexec
>  > is in $PATH for hooks).
> 
> you are right, the call to git-update-server-info does succeed, so there
> is no need to make that change.
> 
> Personally, I find it unfortunate, though, that those scripts rely on
> commands that won't exist when a normal user runs them.
> 
> Just my 2 cents,
> Peter
> 

Anyone can run them, just not from the default $PATH.

In fact, calling the dashed versions from the hooks is both safer and
(marginally) more efficient: Many people have several versions of git
lying around, and we've had more than one "bug" report where people
messed up because of mixing git bits from several versions. Calling the
dashed form above relies on the environment as set up by the caller, not
the user (who may have several "git" in $PATH, but not
"git-update-server-info"). Also, the command is called directly rather
than indirectly with "git" having to look for it.

Michael

Re: [PATCH] post-update.sample referenced obsolete binary "git-update-server-info"

[Peter Simons]

Hi Michael,

 > Calling the dashed versions [is safer]: Many people have several
 > versions of git lying around, and we've had more than one "bug"
 > report where people messed up because of mixing git bits from several
 > versions.

right, this is a good point. Thank you for sharing this insight.

Take care,
Peter