Git development
 help / color / mirror / Atom feed
From: Nicolas Graves <ngraves@ngraves.fr>
To: git@vger.kernel.org
Cc: Cuckoo Aidan <aidancuckoo@gmail.com>
Subject: Error / feature-request: Signing git commits with SSH hardware key
Date: Tue, 11 Oct 2022 20:12:19 +0200	[thread overview]
Message-ID: <875ygqw7p8.fsf@ngraves.fr> (raw)


Hi!

I noticed git commit signing works well with ssh-ed25519 keys, but does
fail with sk-ssh-ed25519@openssh.com SSH hardware keys (with can be
used to clone / post to github for instance).

Would that be possible to support in a later release? Thus having a
smart card can be useful for both ssh and git.

I also noticed a similar error in a previous mail from Cuckoo Aidan
<aidancuckoo@gmail.com>, but he doesn't say which type of key he
used. In any case, would that be possible to include the info about
which type of keys cannot be used to commit in the github guide
https://docs.github.com/en/authentication/managing-commit-signature-verification/telling-git-about-your-signing-key#telling-git-about-your-ssh-key) ?

-- 
Best regards,
Nicolas Graves

             reply	other threads:[~2022-10-11 19:32 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-11 18:12 Nicolas Graves [this message]
2022-10-11 20:41 ` Error / feature-request: Signing git commits with SSH hardware key brian m. carlson
2022-10-11 21:54   ` Nicolas Graves
2022-10-11 22:17     ` Nicolas Graves
2022-10-12  6:54       ` Nicolas Graves
2022-10-12  6:55       ` Fabian Stelzer
2022-10-12  7:22         ` Nicolas Graves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=875ygqw7p8.fsf@ngraves.fr \
    --to=ngraves@ngraves.fr \
    --cc=aidancuckoo@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox