From: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
To: David Aguilar <davvid@gmail.com>
Cc: "Junio C Hamano" <gitster@pobox.com>,
"Git Mailing List" <git@vger.kernel.org>,
"Johannes Schindelin" <Johannes.Schindelin@gmx.de>,
"Alan Blotz" <work@blotz.org>,
"Đoàn Trần Công Danh" <congdanhqx@gmail.com>
Subject: Re: [PATCH 1/4] t7800-difftool: cleanup temporary repositories used by tests
Date: Sun, 19 Sep 2021 15:25:24 +0200 [thread overview]
Message-ID: <875yuwd7a8.fsf@evledraar.gmail.com> (raw)
In-Reply-To: <20210919015729.98323-1-davvid@gmail.com>
On Sat, Sep 18 2021, David Aguilar wrote:
> The "dirlinks" and "growing" repositories should not outlive the
> tests that use them.
Why not? The pattern of not bothering to clean up the work scratch are
is fine as long as it doesn't leave crap around for other tests. See the
referenec to "repo" at[1].
I.e. is this needed for later tests that change in this series, or just
cleanup in case a future test ever cares that there's an untracked
"dirlinks" and "growing" directory at the top-level?
1. https://lore.kernel.org/git/87y27veeyj.fsf@evledraar.gmail.com/
next prev parent reply other threads:[~2021-09-19 13:28 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-19 1:57 [PATCH 1/4] t7800-difftool: cleanup temporary repositories used by tests David Aguilar
2021-09-19 1:57 ` [PATCH 2/4] difftool: add a missing space to the run_dir_diff() comments David Aguilar
2021-09-19 1:57 ` [PATCH 3/4] difftool: use a strbuf to create the tmpdir path David Aguilar
2021-09-19 2:17 ` Jeff King
2021-09-19 2:33 ` [PATCH v2 " David Aguilar
2021-09-20 18:35 ` Junio C Hamano
2021-09-19 9:00 ` [PATCH " Johannes Sixt
2021-09-19 18:13 ` David Aguilar
2021-09-19 18:46 ` Johannes Sixt
2021-09-19 19:28 ` David Aguilar
2021-09-19 19:50 ` Johannes Sixt
2021-09-19 1:57 ` [PATCH 4/4] difftool: fix symlink-file writing in dir-diff mode David Aguilar
2021-09-19 2:02 ` [PATCH v2 " David Aguilar
2021-09-19 2:21 ` [PATCH v3 " David Aguilar
2021-09-19 13:25 ` Ævar Arnfjörð Bjarmason [this message]
2021-09-20 18:28 ` [PATCH 1/4] t7800-difftool: cleanup temporary repositories used by tests Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875yuwd7a8.fsf@evledraar.gmail.com \
--to=avarab@gmail.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=congdanhqx@gmail.com \
--cc=davvid@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=work@blotz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).