From: Sergei Organov <osv@javad.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: Surprising 'git-describe --all --match' behavior.
Date: Fri, 20 Jun 2014 00:12:11 +0400 [thread overview]
Message-ID: <8761jwd5gk.fsf@osv.gnss.ru> (raw)
In-Reply-To: <xmqq38f0hg0h.fsf@gitster.dls.corp.google.com> (Junio C. Hamano's message of "Thu, 19 Jun 2014 12:10:38 -0700")
Junio C Hamano <gitster@pobox.com> writes:
> Sergei Organov <osv@javad.com> writes:
>
>> Will something break if it won't helpfully prepend refs/tags/ once
>> --all is given?
>
> "describe --all --match 'v*'" will no longer match a tag v1.2.3, and
> forces the users to say "describe --match 'refs/tags/v*'",
No,
descirbe --match 'v*'
or
describe --tags --match 'v*'
depending on what they actually meant. Notice my "once --all is given"
above.
Those who used --all meant to match against all the refs, no?
> and these users will probably see it as a new breakage, I would imagine.
But why would anybody use --all --match if they only meant --tags
--match or even just --match alone? Was it historically --all that was
first introduced, maybe?
--
Sergei.
next prev parent reply other threads:[~2014-06-19 20:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-19 13:31 Surprising 'git-describe --all --match' behavior Sergei Organov
2014-06-19 17:20 ` Junio C Hamano
2014-06-19 18:58 ` Sergei Organov
2014-06-19 19:10 ` Junio C Hamano
2014-06-19 20:12 ` Sergei Organov [this message]
2014-06-19 21:50 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8761jwd5gk.fsf@osv.gnss.ru \
--to=osv@javad.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox