From: Miles Bader <miles@gnu.org>
To: John Keeping <john@keeping.me.uk>
Cc: Junio C Hamano <gitster@pobox.com>,
git@vger.kernel.org, Antoine Pelisse <apelisse@gmail.com>
Subject: Re: [PATCH 2/3] combine-diff: suppress a clang warning
Date: Thu, 07 Feb 2013 13:12:59 +0900 [thread overview]
Message-ID: <876224sqwk.fsf@catnip.gol.com> (raw)
In-Reply-To: <20130203231549.GV1342@serenity.lan> (John Keeping's message of "Sun, 3 Feb 2013 23:15:49 +0000")
John Keeping <john@keeping.me.uk> writes:
> I generally like to get rid of the pointless warnings so that the useful
> ones can't hide in the noise. Perhaps "CFLAGS += -Wno-string-plus-int"
> would be better for this particular warning, but when there's only one
> bit of code that triggers it, tweaking that seemed simpler.
An even better approach would be to file a bug against clang ... it
really is a very ill-considered warning -- PTR + OFFS is not just
valid C, it's _idiomatic_ in C for getting interior pointers into
arrays -- and such a warning should never be enabled by default, or by
any standard warning options.
-miles
--
永日の 澄んだ紺から 永遠へ
next prev parent reply other threads:[~2013-02-07 4:13 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-03 14:37 [PATCH 0/3] Make Git compile warning-free with Clang John Keeping
2013-02-03 14:37 ` [PATCH 1/3] fix clang -Wtautological-compare with unsigned enum John Keeping
2013-02-03 19:38 ` Jonathan Nieder
2013-02-03 14:37 ` [PATCH 2/3] combine-diff: suppress a clang warning John Keeping
2013-02-03 18:20 ` Tay Ray Chuan
2013-02-03 19:06 ` John Keeping
2013-02-03 19:58 ` Junio C Hamano
2013-02-03 20:31 ` John Keeping
2013-02-03 21:07 ` Junio C Hamano
2013-02-03 23:15 ` John Keeping
2013-02-04 0:24 ` Junio C Hamano
2013-02-05 20:25 ` [PATCH] t4038: add tests for "diff --cc --raw <trees>" John Keeping
2013-02-05 20:48 ` Junio C Hamano
2013-02-05 21:39 ` [PATCH v2] " John Keeping
2013-02-05 22:27 ` Junio C Hamano
2013-02-07 4:12 ` Miles Bader [this message]
2013-02-07 8:41 ` [PATCH 2/3] combine-diff: suppress a clang warning John Keeping
2013-02-03 14:37 ` [PATCH 3/3] builtin/apply: tighten (dis)similarity index parsing John Keeping
2013-02-03 20:50 ` Junio C Hamano
2013-02-03 17:13 ` [PATCH 0/3] Make Git compile warning-free with Clang Antoine Pelisse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=876224sqwk.fsf@catnip.gol.com \
--to=miles@gnu.org \
--cc=apelisse@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=john@keeping.me.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).