git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Rast <trast@inf.ethz.ch>
To: Nelson Benitez Leon <nelsonjesus.benitez@seap.minhap.es>
Cc: <git@vger.kernel.org>, <peff@peff.net>, <sam@vilain.net>,
	<sam.vilain@catalyst.net.nz>
Subject: Re: [PATCH 1/3] http: authenticate on NTLM proxies and others suppported, by CuRL
Date: Tue, 28 Feb 2012 15:32:33 +0100	[thread overview]
Message-ID: <8762er6nb2.fsf@thomas.inf.ethz.ch> (raw)
In-Reply-To: <4F4CCE01.8080300@seap.minhap.es> (Nelson Benitez Leon's message of "Tue, 28 Feb 2012 13:52:17 +0100")

Nelson Benitez Leon <nelsonjesus.benitez@seap.minhap.es> writes:

> -	if (curl_http_proxy)
> +	if (curl_http_proxy) {
>  		curl_easy_setopt(result, CURLOPT_PROXY, curl_http_proxy);
> +		curl_easy_setopt(result, CURLOPT_PROXYAUTH, CURLAUTH_ANY);
> +	}

There was another attempt at doing the same very recently:

  http://thread.gmane.org/gmane.comp.version-control.git/191140

I could swear there was a second one, but apparently that was you.
Neither you nor Marco submitter have so far answered the question I
raised in

  http://thread.gmane.org/gmane.comp.version-control.git/191155

which can be summarized as: please make a case -- and put it in the
message! -- for or against making this configurable.  Is there a speed
tradeoff?  (However, you could steal some of Daniel Stenberg's
reasoning!)

Note that Marco (the submitter in the first one) has told me privately
that he could not pursue this further right now, so I suppose he'd be
happy if you could finish it.

-- 
Thomas Rast
trast@{inf,student}.ethz.ch

  reply	other threads:[~2012-02-28 14:32 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-28 12:52 [PATCH 1/3] http: authenticate on NTLM proxies and others suppported, by CuRL Nelson Benitez Leon
2012-02-28 14:32 ` Thomas Rast [this message]
2012-02-28 18:15   ` Nelson Benitez Leon
2012-02-28 17:30     ` Thomas Rast

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8762er6nb2.fsf@thomas.inf.ethz.ch \
    --to=trast@inf.ethz.ch \
    --cc=git@vger.kernel.org \
    --cc=nelsonjesus.benitez@seap.minhap.es \
    --cc=peff@peff.net \
    --cc=sam.vilain@catalyst.net.nz \
    --cc=sam@vilain.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).