git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Teemu Likonen <tlikonen@iki.fi>
To: Jonas Fonseca <fonseca@diku.dk>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: [PATCH] asciidoc: add minor workaround to add an empty line after code blocks
Date: Thu, 30 Oct 2008 14:56:15 +0200	[thread overview]
Message-ID: <8763nautqo.fsf@iki.fi> (raw)
In-Reply-To: <20081030104503.GA17131@diku.dk> (Jonas Fonseca's message of "Thu\, 30 Oct 2008 11\:45\:03 +0100")

Jonas Fonseca (2008-10-30 11:45 +0100) wrote:

> Insert an empty <simpara> in manpages after code blocks to force and
> empty line.

>  This is an old issue reported by Theodore Ts'o and fixed partially in
>  commit 63c97ce228f2d2697a8ed954a9592dfb5f286338 for the URL section
>  of the fetch/pull/push manpages. I have fixed this in tig using an
>  approach similar to the attached. Simple and clean, but only tested
>  with docbook-xsl version 1.72 so I have made it conditional.

Thanks. Your patch seems to work and code blocks look much nicer now. I
tested command-line "man" as well as Emacs' "M-x man" and "M-x woman".
I'm using docbook-xsl Debian package version 1.73.2.dfsg.1-4.

Another kind of formatting issue exists with some other example
commands, like in "git rebase" manpage, for example. Not that I care
that much, but here's an example. The asciidoc source (git-rebase.txt)
contains:

    then the command

        git rebase --onto topicA~5 topicA~3 topicA

    would result in the removal of commits F and G:

In final manpage output it looks like this:

    then the command                               

        git rebase --onto topicA~5 topicA~3 topicA 
    would result in the removal of commits F and G:

  reply	other threads:[~2008-10-30 12:57 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-29 19:16 A typesetting problem with git man pages Teemu Likonen
2008-10-29 19:35 ` Jonas Fonseca
2008-10-29 22:22   ` Teemu Likonen
2008-10-30 10:45     ` [PATCH] asciidoc: add minor workaround to add an empty line after code blocks Jonas Fonseca
2008-10-30 12:56       ` Teemu Likonen [this message]
2008-11-01 22:48       ` Junio C Hamano
2008-11-01 23:42         ` Thomas Adam
2008-11-03  0:12           ` Kalle Olavi Niemitalo
2008-10-31  7:37   ` A typesetting problem with git man pages Teemu Likonen
2008-10-31  8:37     ` Teemu Likonen
2008-10-29 19:39 ` Jeff King
2008-10-29 20:14   ` Jonas Fonseca

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8763nautqo.fsf@iki.fi \
    --to=tlikonen@iki.fi \
    --cc=fonseca@diku.dk \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).