git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Toon Claes <toon@iotcl.com>
To: Patrick Steinhardt <ps@pks.im>, git@vger.kernel.org
Cc: Peter Seiderer <ps.report@gmx.net>,
	Junio C Hamano <gitster@pobox.com>,
	Eli Schwartz <eschwartz@gentoo.org>,
	Justin Tobler <jltobler@gmail.com>
Subject: Re: [PATCH v2 1/2] meson: report detected runtime executable paths
Date: Fri, 25 Apr 2025 10:27:12 +0200	[thread overview]
Message-ID: <877c38fxy7.fsf@iotcl.com> (raw)
In-Reply-To: <20250425-pks-meson-posix-shell-v2-1-fddc6123511b@pks.im>

Patrick Steinhardt <ps@pks.im> writes:

> Git needs to know about a couple of executable paths to pick at runtime.
> This includes the system shell, but may also optionally include the Perl
> and Python interpreters. Meson detects the location of these paths
> automatically via `find_program()`, which does a lookup via the `PATH`
> environment variable. As such, it may not be immediately obvious to the
> developer which paths have been autodetected.
>
> Improve this by exposing runtime executable paths at setup time.
>
> Signed-off-by: Patrick Steinhardt <ps@pks.im>
> ---
>  meson.build | 6 ++++++
>  1 file changed, 6 insertions(+)
>
> diff --git a/meson.build b/meson.build
> index c47cb79af08..a180c66ee69 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -2080,3 +2080,9 @@ summary({
>    'sha256': sha256_backend,
>    'zlib': zlib_backend,
>  }, section: 'Backends')
> +
> +summary({
> +  'perl': target_perl,
> +  'python': target_python,
> +  'shell': target_shell,
> +}, section: 'Runtime executable paths')

I appreciate this change. Without [PATCH 2/2] applied I'm getting:

  Runtime executable paths
    perl         : /usr/bin/perl
    python       : /usr/bin/python3
    shell        : /usr/bin/sh

And with [PATHCH 2/2] I'm getting:

  Runtime executable paths
    perl         : /usr/bin/perl
    python       : /usr/bin/python3
    shell        : /bin/sh

As expected. :+1:

--
Toon

  reply	other threads:[~2025-04-25  8:27 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-24 13:38 [PATCH 0/2] meson: prefer '/bin/sh' over PATH lookup Patrick Steinhardt
2025-04-24 13:38 ` [PATCH 1/2] meson: report detected runtime executable paths Patrick Steinhardt
2025-04-25  0:45   ` Eli Schwartz
2025-04-25  5:21     ` Patrick Steinhardt
2025-04-25 16:34       ` Junio C Hamano
2025-04-24 13:38 ` [PATCH 2/2] meson: prefer POSIX-specified shell path Patrick Steinhardt
2025-04-24 20:18   ` Justin Tobler
2025-04-25  5:21     ` Patrick Steinhardt
2025-04-24 18:28 ` [PATCH 0/2] meson: prefer '/bin/sh' over PATH lookup Junio C Hamano
2025-04-25  5:21   ` Patrick Steinhardt
2025-04-25  5:47 ` [PATCH v2 " Patrick Steinhardt
2025-04-25  5:47   ` [PATCH v2 1/2] meson: report detected runtime executable paths Patrick Steinhardt
2025-04-25  8:27     ` Toon Claes [this message]
2025-04-25  5:47   ` [PATCH v2 2/2] meson: prefer POSIX-specified shell path Patrick Steinhardt
2025-04-25  8:35     ` Toon Claes
2025-04-25 10:49     ` brian m. carlson
2025-04-25 11:52       ` Patrick Steinhardt
2025-04-25 11:24   ` [PATCH v2 0/2] meson: prefer '/bin/sh' over PATH lookup Toon Claes
2025-04-25 14:11 ` [PATCH v3 " Patrick Steinhardt
2025-04-25 14:11   ` [PATCH v3 1/2] meson: report detected runtime executable paths Patrick Steinhardt
2025-04-25 14:11   ` [PATCH v3 2/2] meson: prefer shell at "/bin/sh" Patrick Steinhardt
2025-04-25 17:04     ` Junio C Hamano
2025-04-25 18:07       ` Eli Schwartz
2025-04-25 18:51         ` Junio C Hamano
2025-04-25 22:21           ` Eli Schwartz
2025-04-25 20:10         ` brian m. carlson
2025-04-25 22:25           ` Eli Schwartz
2025-04-25 20:13     ` brian m. carlson
2025-05-02 21:16   ` [PATCH v3 0/2] meson: prefer '/bin/sh' over PATH lookup Junio C Hamano
2025-05-02 22:37     ` Eli Schwartz
2025-05-05  6:08       ` Patrick Steinhardt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877c38fxy7.fsf@iotcl.com \
    --to=toon@iotcl.com \
    --cc=eschwartz@gentoo.org \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=jltobler@gmail.com \
    --cc=ps.report@gmx.net \
    --cc=ps@pks.im \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).