From: Tassilo Horn <tsdh@gnu.org>
To: Andrei Rybak <rybak.a.v@gmail.com>
Cc: git@vger.kernel.org, Jeff King <peff@peff.net>,
Paolo Bonzini <pbonzini@redhat.com>, Johannes Sixt <j6t@kdbg.org>
Subject: Re: [PATCH v1 0/3] userdiff: Java updates
Date: Sat, 04 Feb 2023 10:22:18 +0100 [thread overview]
Message-ID: <877cwxvl3a.fsf@gnu.org> (raw)
In-Reply-To: <20230203232339.216592-1-rybak.a.v@gmail.com>
Andrei Rybak <rybak.a.v@gmail.com> writes:
Hi Andrei,
> Three patches to improve builtin userdiff support for Java features.
> Some pretty old features -- type parameters aka generics are actually
> older than Git, and some quite recent features of Java: records and
> sealed classes, released in Java 16 and Java 17 correspondingly, both
> from 2021.
Thanks for including me being the last contributor to java userdiff.
The patches look good from my POV and are safe-guarded with tests, so
I'm all for it.
Bye,
Tassilo
next prev parent reply other threads:[~2023-02-04 9:25 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-03 23:23 [PATCH v1 0/3] userdiff: Java updates Andrei Rybak
2023-02-03 23:23 ` [PATCH v1 1/3] userdiff: support Java type parameters Andrei Rybak
2023-02-03 23:23 ` [PATCH v1 2/3] userdiff: support Java record types Andrei Rybak
2023-02-03 23:23 ` [PATCH v1 3/3] userdiff: support Java sealed classes Andrei Rybak
2023-02-04 9:22 ` Tassilo Horn [this message]
2023-02-04 13:43 ` [PATCH v2 0/3] userdiff: Java updates Andrei Rybak
2023-02-04 13:43 ` [PATCH v2 1/3] userdiff: support Java type parameters Andrei Rybak
2023-02-04 13:43 ` [PATCH v2 2/3] userdiff: support Java record types Andrei Rybak
2023-02-04 13:43 ` [PATCH v2 3/3] userdiff: support Java sealed classes Andrei Rybak
2023-02-05 10:09 ` [PATCH v2 0/3] userdiff: Java updates Johannes Sixt
2023-02-05 19:27 ` Andrei Rybak
2023-02-05 21:33 ` Johannes Sixt
2023-02-07 23:42 ` [PATCH v3 " Andrei Rybak
2023-02-07 23:42 ` [PATCH v3 1/3] userdiff: support Java type parameters Andrei Rybak
2023-02-08 0:04 ` Andrei Rybak
2023-02-07 23:42 ` [PATCH v3 2/3] userdiff: support Java record types Andrei Rybak
2023-02-07 23:42 ` [PATCH v3 3/3] userdiff: support Java sealed classes Andrei Rybak
2023-02-08 20:51 ` [PATCH v3 0/3] userdiff: Java updates Johannes Sixt
2023-02-08 20:55 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877cwxvl3a.fsf@gnu.org \
--to=tsdh@gnu.org \
--cc=git@vger.kernel.org \
--cc=j6t@kdbg.org \
--cc=pbonzini@redhat.com \
--cc=peff@peff.net \
--cc=rybak.a.v@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).