From: "Amadeusz Żołnowski" <aidecoe@aidecoe.name>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, Luke Diamand <luke@diamand.org>
Subject: Re: [PATCH] git-p4.py: Make submit working on bare repository
Date: Mon, 22 Feb 2016 18:50:23 +0000 [thread overview]
Message-ID: <877fhwd1g0.fsf@freja.aidecoe.name> (raw)
In-Reply-To: <xmqqbn7aa522.fsf@gitster.mtv.corp.google.com>
[-- Attachment #1: Type: text/plain, Size: 671 bytes --]
Junio C Hamano <gitster@pobox.com> writes:
> I wonder if it makes sense to just silently allowing submit without
> rebasing, and without telling the user how to clean it up.
It is a good point. Maybe submit shouldn't be allowed by default at all
From bare repository. What do you think about following approach? If
core.base is true, then if git-p4.submitFromBare is also true then
submit without performing proper rebase, but update master ref from
p4/master. If core.base is true, but git-p4.submitFromBare is false,
abort immediately. Submitting from bare repository would require aware
decision from a user.
Kind regards,
--
Amadeusz Żołnowski
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 950 bytes --]
next prev parent reply other threads:[~2016-02-23 2:46 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-17 22:46 [PATCH] git-p4.py: Don't try to rebase on submit from bare repository Amadeusz Żołnowski
2016-02-19 9:47 ` Luke Diamand
2016-02-19 17:21 ` Junio C Hamano
2016-02-19 18:27 ` Amadeusz Żołnowski
2016-02-19 18:40 ` Eric Sunshine
2016-02-19 21:57 ` [PATCH] git-p4.py: Make submit working on " Amadeusz Żołnowski
2016-02-19 22:44 ` Junio C Hamano
2016-02-20 11:00 ` Amadeusz Żołnowski
2016-02-21 7:36 ` Junio C Hamano
2016-02-22 18:50 ` Amadeusz Żołnowski [this message]
2016-02-23 6:59 ` Junio C Hamano
2016-02-23 12:05 ` Luke Diamand
2016-02-23 20:56 ` Amadeusz Żołnowski
2016-02-28 4:26 ` Luke Diamand
2016-02-28 20:46 ` Amadeusz Żołnowski
2016-02-29 15:29 ` Luke Diamand
2016-04-12 23:25 ` Junio C Hamano
2016-04-13 20:27 ` Amadeusz Żołnowski
2016-04-13 21:47 ` Junio C Hamano
2016-06-07 20:32 ` Amadeusz Żołnowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877fhwd1g0.fsf@freja.aidecoe.name \
--to=aidecoe@aidecoe.name \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=luke@diamand.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).