From: Thomas Rast <trast@inf.ethz.ch>
To: Junio C Hamano <gitster@pobox.com>
Cc: Thomas Rast <trast@student.ethz.ch>, <git@vger.kernel.org>
Subject: Re: [PATCH] xdiff: load full words in the inner loop of xdl_hash_record
Date: Mon, 12 Mar 2012 21:13:22 +0100 [thread overview]
Message-ID: <877gypr319.fsf@thomas.inf.ethz.ch> (raw)
In-Reply-To: <7vmx7lsmjd.fsf@alter.siamese.dyndns.org> (Junio C. Hamano's message of "Mon, 12 Mar 2012 11:26:46 -0700")
Junio C Hamano <gitster@pobox.com> writes:
> Thomas Rast <trast@student.ethz.ch> writes:
>
>> Also definitely post-v1.7.10 material, but I figure many people will
>> be interested. Since it's such a central part of much of git, it's
>> also quite important that it gets tested heavily.
>
> I am interested but this is a material not beyond 'pu'. Until it
> learns to be nice on platforms that do not like unaligned accesses
> or use big endian, that is.
Umm, nice how? It leaves in the old version for those platforms. I can
perhaps make it #error if we are unhappy about the user's platform, but
that's about it. Testing for endianness is possible, but testing for
unaligned access risks SIGBUS and thus requires spawning a helper
program.
--
Thomas Rast
trast@{inf,student}.ethz.ch
next prev parent reply other threads:[~2012-03-12 20:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-12 15:10 [PATCH] xdiff: load full words in the inner loop of xdl_hash_record Thomas Rast
2012-03-12 18:26 ` Junio C Hamano
2012-03-12 20:13 ` Thomas Rast [this message]
2012-03-12 20:59 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877gypr319.fsf@thomas.inf.ethz.ch \
--to=trast@inf.ethz.ch \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=trast@student.ethz.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).