git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/7] .git directory should be ignored
@ 2007-03-03 10:18 Xavier Maillard
  2007-03-03 22:05 ` Junio C Hamano
  0 siblings, 1 reply; 4+ messages in thread
From: Xavier Maillard @ 2007-03-03 10:18 UTC (permalink / raw)
  To: git; +Cc: julliard


Add .git to the list of extensions to be ignored

Signed-off-by: Xavier Maillard <zedek@gnu.org>
---
 contrib/emacs/vc-git.el |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/contrib/emacs/vc-git.el b/contrib/emacs/vc-git.el
index a2d3932..3d43ca0 100644
--- a/contrib/emacs/vc-git.el
+++ b/contrib/emacs/vc-git.el
@@ -149,4 +149,7 @@
 ;;    (and (looking-at "[0-9a-f]+")
 ;;         (buffer-substring (match-beginning 0) (match-end 0)))))
 
+;;;###autoload
+(add-to-list 'completion-ignored-extensions ".git/")
+
 (provide 'vc-git)
-- 
1.5.0

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH 1/7] .git directory should be ignored
  2007-03-03 10:18 [PATCH 1/7] .git directory should be ignored Xavier Maillard
@ 2007-03-03 22:05 ` Junio C Hamano
  2007-03-04 22:02   ` Alexandre Julliard
  2007-03-05  8:02   ` Xavier Maillard
  0 siblings, 2 replies; 4+ messages in thread
From: Junio C Hamano @ 2007-03-03 22:05 UTC (permalink / raw)
  To: Xavier Maillard; +Cc: git, julliard

Xavier Maillard <zedek@gnu.org> writes:

> Add .git to the list of extensions to be ignored
>
> Signed-off-by: Xavier Maillard <zedek@gnu.org>
> ---
>  contrib/emacs/vc-git.el |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/contrib/emacs/vc-git.el b/contrib/emacs/vc-git.el
> index a2d3932..3d43ca0 100644
> --- a/contrib/emacs/vc-git.el
> +++ b/contrib/emacs/vc-git.el
> @@ -149,4 +149,7 @@
>  ;;    (and (looking-at "[0-9a-f]+")
>  ;;         (buffer-substring (match-beginning 0) (match-end 0)))))
>  
> +;;;###autoload
> +(add-to-list 'completion-ignored-extensions ".git/")
> +
>  (provide 'vc-git)

I am no Emacs vc expert to judge, but I wonder if it is kosher
to muck with that global variable from a vc backend.

The above does mirror what pcl-cvs does for "CVS/" but I notice
that vc-cvs.el does not do so, neither vc-rcs.el excludes
"RCS/".

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 1/7] .git directory should be ignored
  2007-03-03 22:05 ` Junio C Hamano
@ 2007-03-04 22:02   ` Alexandre Julliard
  2007-03-05  8:02   ` Xavier Maillard
  1 sibling, 0 replies; 4+ messages in thread
From: Alexandre Julliard @ 2007-03-04 22:02 UTC (permalink / raw)
  To: Junio C Hamano; +Cc: Xavier Maillard, git

Junio C Hamano <junkio@cox.net> writes:

> I am no Emacs vc expert to judge, but I wonder if it is kosher
> to muck with that global variable from a vc backend.
>
> The above does mirror what pcl-cvs does for "CVS/" but I notice
> that vc-cvs.el does not do so, neither vc-rcs.el excludes
> "RCS/".

Yes, I think if we really want to do this, it should be done in
git.el, not in vc-git.

-- 
Alexandre Julliard
julliard@winehq.org

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 1/7] .git directory should be ignored
  2007-03-03 22:05 ` Junio C Hamano
  2007-03-04 22:02   ` Alexandre Julliard
@ 2007-03-05  8:02   ` Xavier Maillard
  1 sibling, 0 replies; 4+ messages in thread
From: Xavier Maillard @ 2007-03-05  8:02 UTC (permalink / raw)
  To: Junio C Hamano; +Cc: git, julliard

   From: Junio C Hamano <junkio@cox.net>

   Xavier Maillard <zedek@gnu.org> writes:

   > Add .git to the list of extensions to be ignored
   The above does mirror what pcl-cvs does for "CVS/" but I notice
   that vc-cvs.el does not do so, neither vc-rcs.el excludes
   "RCS/".

Oops wrong file /o\. Iintended to do this into git.el... Please
ignore. Iwill double-check my future contributions before sending
it here.

Sorry
-- 
Xavier

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2007-03-05  8:05 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-03-03 10:18 [PATCH 1/7] .git directory should be ignored Xavier Maillard
2007-03-03 22:05 ` Junio C Hamano
2007-03-04 22:02   ` Alexandre Julliard
2007-03-05  8:02   ` Xavier Maillard

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).